Skip to content

fix(har): guard HAR logging when a request matches no mock [RQ-2398] #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dinex-dev wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(har): guard HAR logging when a request matches no mock [RQ-2398] #40

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f621659
fix(har): guard HAR logging when a request matches no mock [RQ-2398]
dinex-dev Jul 30, 2026
6f3f3a0
fix(har): await storeLog so async rejections are caught
dinex-dev Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 22 additions & 8 deletions src/middlewares/har.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,29 @@ export const HarMiddleware = (req: Request, res: Response, next: NextFunction) =
return originalSend.call(this, body);
};

res.once('finish', () => {
const HarEntry: Partial<Entry> = {
time: Date.now() - requestStartTime.getTime(),
startedDateTime: requestStartTimeStamp,
request: buildHarRequest(req),
response: buildHarResponse(res, { body: responseBody }),
}
res.once('finish', async () => {
try {
const mockId = res.locals.rq_metadata?.mockId;
// No matching mock (e.g. 404) means there's nothing to attach the log to.
if (!mockId) {
return;
}

const HarEntry: Partial<Entry> = {
time: Date.now() - requestStartTime.getTime(),
startedDateTime: requestStartTimeStamp,
request: buildHarRequest(req),
response: buildHarResponse(res, { body: responseBody }),
}

storageService.storeLog({ mockId: res.locals.rq_metadata.mockId, HarEntry, })
// Await so a rejected storeLog is caught here rather than surfacing
// as an unhandled rejection.
await storageService.storeLog({ mockId, HarEntry, })
} catch (error) {
// Never let a logging failure escape the finish handler — it would
// surface as an uncaught exception and can crash the process.
console.error("[HarMiddleware] Failed to store log", error);
}
});

next();
Expand Down
Loading