fix(ci): grant pull-requests: read to the semantic-PR check - #184
Merged
Conversation
The workflow granted contents: read, but common-check-semantic-pr.yml needs pull-requests: read to inspect the PR title -- and a callee may not request more than it is granted, so the run was rejected before any job started. This is the second half of the fix: the earlier change repointed the reference from a pinned SHA that predates the file to @main, which resolved the workflow; this grants it the permission it actually needs. Between the two, PR titles have not been validated in this repo since the reference broke. Signed-off-by: Jimisola Laursen <jimisola@jimisola.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ⓘ PR titles have not actually been validated in this repo for some time — this is the second half of the fix.
What & Why
The workflow granted
contents: read, butcommon-check-semantic-pr.ymlneedspull-requests: readto inspect the PR title. A callee may not request more than it is granted, so the run is rejected before any job starts.Two separate bugs stacked here:
common-rename), so it resolved to nothing. Fixed in the release-flow PR.Between the two, PR-title validation has been silently dead. As always with this failure mode: a startup failure produces no check run, so it never appeared in the checks list.
Found by an org-wide caller/callee permission audit.
Author checklist
actionlintcleanTest Plan
This PR itself exercises it —
Check Semantic PRshould now run and pass rather than startup-fail. Note thepull_request_targetleg reads the workflow from the base branch, so that leg only turns green after merge.