fix(build): declare the extensions.xml namespace so Renovate tracks Nisse - #183
Merged
Conversation
…isse Renovate parses `.mvn/extensions.xml` by default, but its maven manager rejects the file outright unless the root element carries a recognised EXTENSIONS namespace -- parseExtensions() returns null when `attr.xmlns` is not one of EXTENSIONS/1.0.0, 1.1.0 or 1.2.0, and the file is then skipped with no warning. Ours declared no xmlns at all, so Nisse would have sat at 0.9.5 indefinitely while every other dependency in the repo kept moving. Silent, and exactly the kind of rot the pin was supposed to avoid. Verified that Maven still resolves the version with the namespace present: tagging 9.9.9 and running `mvn help:evaluate -Dexpression=project.version` prints 9.9.9, unchanged. Signed-off-by: Jimisola Laursen <jimisola@jimisola.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ⓘ Follow-up to the git-derived versioning change. Small, but it is the difference between Nisse being maintained and never being updated again.
What & Why
Renovate parses
.mvn/extensions.xmlby default — it is in the maven manager’s default file patterns. But it rejects the file outright unless the root element carries a recognised namespace. Fromlib/modules/manager/maven/extract.ts:Ours declared no
xmlnsat all, soattr.xmlnswasundefined, the file was skipped, and Nisse would have sat at 0.9.5 indefinitely while every other dependency in the repo kept moving. No warning, no PR, nothing to notice — exactly the kind of silent rot pinning a version is meant to prevent.(0.9.5 is current as of today — released 2026-08-10. The problem is the future, not the present.)
Verification
The namespace is not just cosmetic to Maven, so I checked it does not change resolution:
Unchanged. CI on this PR builds the project for real.
Author checklist