[deps] Dependency update: sdk-go - #454
Conversation
|
|
||
| go 1.26.1 | ||
|
|
||
| require ( |
There was a problem hiding this comment.
does this need a rebase maybe?
not sure why these lines would be deleted for this dep update.
There was a problem hiding this comment.
No rebase needed — the branch is already on top of main (merge-base is the current origin/main).
The deleted lines in dagger/go.mod are indirect dependencies that go mod tidy removed after upgrading github.com/1password/onepassword-sdk-go from v0.1.7 to v0.4.1. The newer SDK no longer pulls in the OpenTelemetry/Dagger otel stack, so github.com/dagger/otel-go, go.opentelemetry.io/otel/sdk, and their transitive deps are no longer required. We also added a follow-up commit (da8e995) to adapt dagger/secret.go to the 1Password SDK v0.4.1 API.
Verification:
make build/go build ./...passes for the root module.make testpasses for unit tests (pact tests need the pact CLI, which is present in CI).- CI
test,build, andscanchecks are green; the remaining e2e jobs are in progress.
There was a problem hiding this comment.
Hi @kriscoleman — thanks for the review. This is resolved:
- The branch was already on top of
main(no rebase needed). - The deleted lines in
dagger/go.modwere indirect OpenTelemetry/Dagger otel dependencies thatgo mod tidyremoved after upgradinggithub.com/1password/onepassword-sdk-gofromv0.1.7tov0.4.1. The newer SDK no longer pulls them in. dagger/secret.gowas adapted to the v0.4.1 API in commitda8e995(client.Items().List,client.Secrets().Resolve, etc.).- CI is now passing on the latest commit (
testandbuildgreen;scanande2ejobs are still running).
Could you take another look and dismiss/request changes as needed?
This PR was generated by the vandoor-update-sdk-go Factory workflow.
- Replace Items.ListAll iterator with Items().List slice\n- Replace Secrets.Resolve with Secrets().Resolve\n- Remove deprecated ErrorIteratorDone reference
113085e to
f4d65b7
Compare
- Root module: bump k8s.io/* to v0.36.4, plus patch updates to cloudflare/circl, fxamacker/cbor/v2, go-openapi/swag, mattn/go-runewidth, santhosh-tekuri/jsonschema/v6, and google.golang.org/protobuf - Dagger module: bump ianlancetaylor/demangle and google.golang.org/protobuf
1 participant
This PR was generated by the vandoor-update-sdk-go Factory workflow.
What does this PR do?
Updates Go dependencies for the replicated-sdk project and adapts the Dagger pipeline to the upgraded 1Password SDK API.
Changes
Root module (
go.mod):github.com/replicatedhq/kotskinds:v0.0.0-20260513164854-d3c205b56eb4→v0.1.0github.com/stretchr/testify:v1.11.1→v1.12.1go.yaml.in/yaml/v3:v3.0.4→v3.0.5helm.sh/helm/v3:v3.21.3→v3.21.4k8s.io/api:v0.36.3→v0.36.4k8s.io/apimachinery:v0.36.3→v0.36.4k8s.io/cli-runtime:v0.36.3→v0.36.4k8s.io/client-go:v0.36.3→v0.36.4github.com/cloudflare/circl,github.com/fxamacker/cbor/v2,github.com/go-openapi/swagand its subpackages,github.com/mattn/go-runewidth,github.com/santhosh-tekuri/jsonschema/v6, andgoogle.golang.org/protobufgo mod tidy.Dagger module (
dagger/go.mod):github.com/1password/onepassword-sdk-go:v0.1.7→v0.4.1github.com/ianlancetaylor/demangleandgoogle.golang.org/protobufgo mod tidybecause the newer 1Password SDK no longer requires them.Dagger code (
dagger/secret.go):client.Items().List,client.Secrets().Resolve, etc.).Does this PR introduce a user-facing change?