docs: align cancel + failure-billing wording with the API - #60
Merged
Conversation
- cancel_job cancels running jobs too (and stops the upstream execution) - job lifecycle: running -> cancelled edge; timeout billing corrected (JOB_TIMEOUT consumed compute and is billed; RUNNER_TIMEOUT never started and is not charged)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two accuracy fixes against current API behavior:
cancel_jobcancelsrunningjobs too on every surface, and stops the upstream execution. The tool table said waiting/dispatched only.RUNNER_TIMEOUT); a job that ran past its plan limit fails withJOB_TIMEOUTand is billed for the compute it consumed. The state diagram also gains therunning -> cancellededge.Wording only, no structural changes.