Refactor/deduplicate utils - #3
Open
renderffx wants to merge 2 commits into
Open
Conversation
- Replace npm with pnpm (package-lock.json -> pnpm-lock.yaml) - Add pnpm-workspace.yaml for monorepo config - Restructure packages into packages/ and apps/ directories - Add suspense-core, sledge-cache, react-sledge, use-from-scratch packages - Add demo app - Add shared tsconfig.base.json and .npmrc
…s utilities - Centralize normalizeError, isThenable, setThenableStatus into src/lib/utils.ts - Eliminate 3 duplicate normalizeError definitions across the codebase - Eliminate 4 inline isThenable duck-checks in favor of shared import - Replace repeated (promise as unknown as Record) casts with typed stampPromise helper - Remove dead instanceof Error check in getResource (reason always normalized) - Fix renderWithSuspense loop bound to accurately express '1 initial + N retries'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.