Skip to content

x64: pass by-value dynamic arrays as pointer value on FPC 3+ #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TetzkatLipHoka wants to merge 1 commit into
base: master
Choose a base branch
from
Open

x64: pass by-value dynamic arrays as pointer value on FPC 3+ #315

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions Source/x64.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -760,11 +760,14 @@ _XMM0: Double;
Result := True;
exit;
end else begin
{$IFDEF FPC}
{$IF DEFINED(FPC) AND (FPC_VERSION < 3)}
{ kept for the old FPC 2.4 ABI this branch was written for }
StoreReg(IPointer(FVar.Dta));
{$ELSE}
{ a dynamic array is a pointer: pass its value, not the slot
address (FPC 3.x x86_64 crashed / read garbage here) }
StoreReg(IPointer(FVar.Dta^));
{$ENDIF}
{$IFEND}
end;
end;
btSet,
Expand Down