Raise instead of silently dropping a property with an unresolved type#307
Open
TetzkatLipHoka wants to merge 1 commit into
Open
Raise instead of silently dropping a property with an unresolved type#307TetzkatLipHoka wants to merge 1 commit into
TetzkatLipHoka wants to merge 1 commit into
Conversation
TPSCompileTimeClass.RegisterProperty freed the half-built property and returned silently when its type string referenced a type that was not (yet) registered. Scripts using the property then failed with a bare 'Unknown identifier' - very hard to trace back to a wrong registration order in an import unit. This is the actual root cause behind reports like issue remobjects#255 ('Delphi 11 case sensitive'). Raise EPSCompilerException naming the property and its type string instead, matching how AddTypeS and the other registration APIs report bad input. Inside OnUses the exception surfaces as a regular compiler error message. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TPSCompileTimeClass.RegisterProperty freed the half-built property and
returned silently when its type string referenced a type that was not
(yet) registered. Scripts using the property then failed with a bare
'Unknown identifier' - very hard to trace back to a wrong registration
order in an import unit. This is the actual root cause behind reports
like issue #255 ('Delphi 11 case sensitive').
Raise EPSCompilerException naming the property and its type string
instead, matching how AddTypeS and the other registration APIs report
bad input. Inside OnUses the exception surfaces as a regular compiler
error message.
Fixes #255 (the reported "case sensitivity" is actually this silent registration failure: the property is dropped and the script then fails with Unknown identifier).
🤖 Generated with Claude Code