Report which LoadData stage failed instead of failing silently#306
Open
TetzkatLipHoka wants to merge 1 commit into
Open
Report which LoadData stage failed instead of failing silently#306TetzkatLipHoka wants to merge 1 commit into
TetzkatLipHoka wants to merge 1 commit into
Conversation
Several failure paths inside LoadTypes/LoadProcs/LoadVars only return False without calling CMD_Err. LoadData then cleared the instance and returned False with ExceptionCode still erNoError, so hosts printing TIFErrorToString(ExceptionCode, ExceptionString) showed 'No Error' for a failed load. Each stage now reports a stage-specific erCustomError - but only when no more specific error is pending (ExEx = erNoError), so existing detailed errors like 'Out Of Range' or 'Unexpected End Of File' are preserved. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several failure paths inside LoadTypes/LoadProcs/LoadVars only return
False without calling CMD_Err. LoadData then cleared the instance and
returned False with ExceptionCode still erNoError, so hosts printing
TIFErrorToString(ExceptionCode, ExceptionString) showed 'No Error' for
a failed load.
Each stage now reports a stage-specific erCustomError - but only when
no more specific error is pending (ExEx = erNoError), so existing
detailed errors like 'Out Of Range' or 'Unexpected End Of File' are
preserved.
🤖 Generated with Claude Code