Fix operator precedence hole in IsCompatibleType#302
Open
TetzkatLipHoka wants to merge 1 commit into
Open
Conversation
One line of the big compatibility expression was missing parentheses:
(((p1.basetype = btPchar) or (p1.BaseType = btString)) and
(p2.BaseType = btWideString) or (p2.BaseType = btUnicodeString)) or
'and' binds stronger than 'or', so the (p2 = btUnicodeString) term stood
alone: ANY destination type was considered assignment-compatible with a
UnicodeString source. Since script 'string' is btUnicodeString nowadays,
these all compiled without error and only failed at runtime (or
corrupted data):
var i: Integer; s: string; ... i := s;
var b: Boolean; s: string; ... b := s;
var d: Double; s: string; ... d := s;
With the added parentheses the term applies - as clearly intended - only
to btPchar/btString destinations. String-to-string, WideString and Char
conversions keep compiling as before.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One line of the big compatibility expression was missing parentheses:
(((p1.basetype = btPchar) or (p1.BaseType = btString)) and
(p2.BaseType = btWideString) or (p2.BaseType = btUnicodeString)) or
'and' binds stronger than 'or', so the (p2 = btUnicodeString) term stood
alone: ANY destination type was considered assignment-compatible with a
UnicodeString source. Since script 'string' is btUnicodeString nowadays,
these all compiled without error and only failed at runtime (or
corrupted data):
var i: Integer; s: string; ... i := s;
var b: Boolean; s: string; ... b := s;
var d: Double; s: string; ... d := s;
With the added parentheses the term applies - as clearly intended - only
to btPchar/btString destinations. String-to-string, WideString and Char
conversions keep compiling as before.
🤖 Generated with Claude Code