chore: rename the local front door to local-edge - #39
Conversation
`evidence-gateway` named the local Caddy service that terminates TLS on 4341, which now collides with the noun for an authority's Evidence deployment. It was never only an Evidence front door either: the same instance answers the Relay and Mint hostnames a hermetic local run needs, and the repo already spells that role `esignet-edge` elsewhere. The service is now `local-edge`, pinned by `LOCAL_EDGE_IMAGE`, published on `SOLMARA_LOCAL_EDGE_PORT`. The default port is unchanged, so only a developer who overrode the old variable has anything to set. Nothing hosted references this service. The CI job and the release-candidate step names drop `authority-cell` too, along with the last two comments carrying it. Hostnames, volume paths, and directory names keep their spelling, as in the wording pass. Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3764acae7a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| evidence-gateway: | ||
| image: ${EVIDENCE_GATEWAY_IMAGE:?versions.env must pin Caddy} | ||
| local-edge: |
There was a problem hiding this comment.
When a developer updates while the existing lab stack is running, Compose treats evidence-gateway as an orphan rather than recreating it as local-edge. The canonical just up and just up-esignet recipes in justfile:89-93 invoke up --force-recreate without --remove-orphans, so the old container remains bound to port 4341 and this renamed service cannot start. Docker documents --remove-orphans as removing services no longer defined in the Compose file; add that cleanup to the recipes or provide an equivalent migration step.
AGENTS.md reference: AGENTS.md:L19-L21
Useful? React with 👍 / 👎.
1 participant
Follow-up to #38, closing the three loose ends flagged there.
1. The
evidence-gatewaycollisionThe local Compose service that terminates TLS on 4341 was named
evidence-gateway, which after #38 names something else entirely. It is alsonot only an Evidence front door: the same Caddy instance carries the Relay and
Mint hostname aliases the hermetic local run needs, and
esignet-edgealreadyestablishes the
-edgespelling for this role incompose.esignet.yaml.evidence-gateway→local-edgeEVIDENCE_GATEWAY_IMAGE→LOCAL_EDGE_IMAGESOLMARA_EVIDENCE_GATEWAY_PORT→SOLMARA_LOCAL_EDGE_PORTThe default port is still 4341, so only a developer who overrode the old
variable has anything to set. No
compose.coolify*.yamlreferences thisservice, so nothing hosted moves.
2. CI naming
authority-cell-checks→lab-checks, plus the four step names inci.ymland
release-candidate.yml. Checked first:mainhas no branch protection andno rulesets, so no required check name breaks. The release-candidate failure-log
step also had to follow the service rename.
3. The two remaining comments
versions.envnow says "authority-owned reset", matchingdocs/hosted-deployment.md, and the interior signer header says "InteriorEvidence gateways".
A dated changelog entry records the rename, since
SOLMARA_LOCAL_EDGE_PORTisthe one developer-visible break.
Verification
Tests were updated first and went red (4 failures across
test_image_pins.pyandtest_runtime_topology.py) before the rename landed.just lintgreenjust testgreen: 302 Python, 143 portal, 62 homejust composegreen, including the eSignet overlay and the hosted andCoolify compose checks