fix(hosted): give routed eSignet proxies Coolify-resolvable names - #33
Merged
Conversation
Coolify validates a routed service against the compose key but resolves it after rewriting "-" to "_", so a hyphenated name is stored where the router never reads it and the domain can only be set from the UI. Name the two routed proxies with underscores so the issuer edge is manageable. Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issuer edge added in #32 cannot be routed: Coolify accepts a
docker_compose_domainsentry only when the name matches a compose service key(
ApplicationsController::update_by_uuid), but resolves it after rewriting-to
_(bootstrap/helpers/parsers.php). A hyphenated name is therefore storedunder a key routing never reads, and only the UI can set it.
Renames the two routed hosted services to
esignet_uiandesignet_edge.esignet_uikeeps its existing domain entry, whose key is already thenormalized form. Unrouted services and the local compose keep hyphens.
Test asserts every routed hosted eSignet service carries a hyphen-free name.