Skip to content

mailsec: require the campaign preview token in CLI guidance - #349

Merged
maximelb merged 3 commits into
masterfrom
codex/mailsec-campaign-confirm-token-20260830
Sep 1, 2026
Merged

mailsec: require the campaign preview token in CLI guidance#349
maximelb merged 3 commits into
masterfrom
codex/mailsec-campaign-confirm-token-20260830

Conversation

@maximelb

@maximelb maximelb commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Summary

  • correct the SDK and CLI contract: campaign execution needs the member-bound token returned by preview, not the campaign id
  • update examples and option help so an operator can complete the guarded preview/confirm flow
  • add regressions for the SDK wire value, rendered CLI guidance, and unchanged CLI token/action/reason forwarding

Safety

This does not weaken the server-side member-set binding or perform any live campaign mutation. The token is still forwarded unchanged and the collector re-derives it against current membership.

Verification

  • python3 -m pytest -o addopts='' -q tests/unit/test_sdk_mailsec.py tests/unit/test_cli_mailsec.py (36 passed)
  • complete local unit/microbenchmark suite in an isolated dev install (3,985 passed, 5 skipped)
  • local sdist and wheel build succeeded

lcbill
lcbill previously approved these changes Aug 30, 2026
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@maximelb
maximelb merged commit 989d3e4 into master Sep 1, 2026
6 checks passed
@maximelb
maximelb deleted the codex/mailsec-campaign-confirm-token-20260830 branch September 1, 2026 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants