fix persisted bun lockfile recovery#6660
Conversation
Greptile SummaryThis PR updates a docstring in
Confidence Score: 4/5Safe to merge as-is, but the advertised fix is not present — the frozen-lockfile recovery still requires manual user intervention. The only functional change is a docstring correction. No existing behavior is broken, but the advertised fix (automatic retry without --frozen-lockfile) is entirely absent from the implementation. reflex/utils/js_runtimes.py — the frozen-lockfile branch at line 501 needs the retry logic the PR description promises. Important Files Changed
|
|
hey @masenf can you look into this? |
|
We can't automatically ignore the user's lock file. Choosing to relock by deleting the My other PR #6658 always syncs the |
|
hey @masenf I removed the automatic relock/retry behavior. The frozen-lockfile mismatch now exits with explicit guidance telling Validation:
|
What changed
bun install --frozen-lockfilefails because the recoveredpackage.jsonand persistedbun.lockareout of sync.
--frozen-lockfileso Bun can reconcile the files.Why
A persisted
bun.lockcould contain updated dependencies while the persistedpackage.jsonremained stale. Thiscaused
reflex runto fail and required users to manually deletereflex.lock.The new recovery flow regenerates the mismatched lockfile automatically, allowing the application to start normally.
Fixes #6657
Validation
uv run pytest tests/units/test_prerequisites.py -quv run ruff check reflex/utils/js_runtimes.py tests/units/test_prerequisites.pygit diff --check