use images from integration docs package instead of github#6435
Conversation
Greptile SummaryThis PR replaces the
Confidence Score: 3/5Safe conceptually but the directory-vs-symlink unlink edge case can crash app startup and should be addressed before merging. One P1 finding: Path.unlink() on a regular directory raises IsADirectoryError, which would surface as an unhandled exception during app initialization if a directory exists at the symlink target path. All callsite changes are straightforward and correct. packages/reflex-site-shared/src/reflex_site_shared/integrations.py — specifically the dst.unlink() call inside _integrations_logos_url() Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[get_integration_logo_url called] --> B{_integrations_logos_url cached?}
B -- Yes --> G[return cached URL prefix]
B -- No --> C[locate integrations_docs logos dir]
C --> D{src dir exists?}
D -- No --> E[raise RuntimeError]
D -- Yes --> F{REFLEX_BACKEND_ONLY?}
F -- Yes --> G2[skip symlink, return URL]
F -- No --> H{dst is correct symlink?}
H -- Yes --> G3[return URL prefix]
H -- No --> I{dst is symlink or exists?}
I -- Yes --> J["dst.unlink() - fails if plain dir"]
I -- No --> K[dst.symlink_to src]
J --> K
K --> G3
Reviews (1): Last reviewed commit: "use images from integration docs package..." | Re-trigger Greptile |
Merging this PR will not alter performance
Comparing Footnotes
|
No description provided.