-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(plotly): add per-chart locale support #6428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BABTUNA
wants to merge
1
commit into
reflex-dev:main
Choose a base branch
from
BABTUNA:feat-6101-plotly-locale
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plotly.js-locales@3.5.0is unconditionally added to the import map, andadd_custom_code()always emits the two helper functions that reference it. This means every app that usesrx.plotly(even with nolocaleprop) will bundle all 70+ locale definitions and include the helper code, adding unnecessary weight for users who never touch the locale feature.A conditional approach would require
add_importsandadd_custom_codeto only emit locale-related output when the component is actually configured with a locale, which isn't easy at the class level. At minimum, the trade-off should be noted in the docstring or changelog so users are aware of the bundle size impact.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree. see how we handle it in moment.py when the user supplies the tz prop. the import should be added conditionally based on the locale prop being provided
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pattern from
moment.pyis clear. Here's how to apply it to the plotlyadd_imports:Same idea applies to
add_custom_code— it should also gate the locale helper functions behindif self.locale is not Noneso the helper code is only emitted when a locale is actually used.Tip: You can customize Greptile's behavior for this repo with
.greptile/rules.mdand.greptile/config.json.