Conversation
Consumes the readline-side fixes and features from v1.3.0, notably the completer panic recovery (reeflective/readline#116): readline now recovers from a panicking application completer at its own boundary, so console's completer no longer needs to guard against it. Also picks up the right-edge redraw fix, the history out-of-range fix, and the new paste-transformer and inline-suggestion APIs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #86 +/- ##
=======================================
Coverage 22.54% 22.54%
=======================================
Files 27 27
Lines 2045 2045
=======================================
Hits 461 461
Misses 1554 1554
Partials 30 30 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
github.com/reeflective/readlinefrom v1.2.2 to v1.3.0.Why
The main driver is the completer panic recovery (reeflective/readline#116): readline now recovers from a panicking application completer at its own boundary and surfaces a completion error message instead of crashing the shell. This is the upstream fix for #81 — console's completer no longer needs to guard itself against panics.
Also picked up in v1.3.0:
memory.GetLine.Shell.PasteTransformer) and inline suggestions (Set/Get/ClearInlineSuggestion+inline-suggest-*commands) — available to console consumers if desired.Changes
Only
go.mod/go.sum(version line + checksums). No source changes required.Testing
go build ./...,go vet ./..., andgo test ./...all pass against readline v1.3.0.