Skip to content

DOC-2123: Update Console ACL UI references for new atomic-ACL design#568

Open
micheleRP wants to merge 6 commits intomainfrom
DOC-2123-console-acl-ui-refresh
Open

DOC-2123: Update Console ACL UI references for new atomic-ACL design#568
micheleRP wants to merge 6 commits intomainfrom
DOC-2123-console-acl-ui-refresh

Conversation

@micheleRP
Copy link
Copy Markdown
Contributor

@micheleRP micheleRP commented Apr 30, 2026

Summary

Refresh Cloud-only Console references ahead of Console's redesigned Security page. The shipped layout (per Jan's recorded demo) is Users / Roles / Permissions — three tabs, no standalone ACLs page. ACLs are managed per principal from the user or role detail page. ACL/RBAC procedural content single-sourced from the docs repo flows in automatically via tag::single-source[]; this PR covers only the Cloud pages that are not single-sourced. Companion PR: redpanda-data/docs#1689.

  • create-dedicated-cloud-cluster.adoc: rewrite the user/ACL walkthrough to follow the real flow — create the user, click Go to user details from the success dialog, then + Add ACL under the user's ACLs section. Field labels match the Add ACL modal (Resource Type, Pattern Type, Resource Name, Operation, Permission, Host).
  • serverless.adoc, cloud-authentication.adoc: drop the wrong "Security > ACLs" path; route users through Users/Roles detail pages instead.
  • whats-new-cloud.adoc: add a May 2026 entry describing the three-tab layout, per-principal ACL management, and the three actions on a principal's ACLs section (+ Add ACL, Allow all operations, Delete selected for bulk delete).

Inline // TODO DOC-2123 comment flags one customer-benefit phrasing for Jan/Martin to confirm.

Context

See the docs-repo PR description for the full open-questions list to Jan/Martin.

Preview pages

Test plan

  • npm run build && npm run serve passes locally
  • Single-source content from the docs repo (acl.adoc, rbac-dp/gbac-dp partials) renders correctly under security/authorization/
  • Walk the updated dedicated-cluster quickstart against a real Console build before merge — defer until Console GA
  • Resolve every // TODO DOC-2123 comment before merge
  • Revert local-antora-playbook.yml — set the redpanda-data/documentation branches back to [main, v/*, shared, site-search] (currently points at DOC-2123-console-acl-ui-refresh for cross-PR preview)

🤖 Generated with Claude Code

Refresh Cloud-only Console references ahead of Console's new Security
page. ACL/RBAC behavior single-sourced from the docs repo flows in
automatically via tag::single-source[]; this commit covers the pages
that are not single-sourced.

- create-dedicated-cloud-cluster.adoc: rewrite the user/ACL walkthrough
  to match the new atomic ACL form (Principal, Resource type, Pattern
  type, Resource name, Operation, Permission, Host) instead of the old
  "click the user, add permissions" flow.
- serverless.adoc: split the single "Security page" reference into
  Security > Users / Security > ACLs / Security > Roles.
- cloud-authentication.adoc: same split for the impersonation
  permissions guidance (lines 128, 135).

Inline // TODO DOC-2123 comments mark form labels that need final
confirmation from Jan/Martin once the new Security page ships.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@micheleRP micheleRP requested a review from a team as a code owner April 30, 2026 23:09
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 30, 2026

Deploy Preview for rp-cloud ready!

Name Link
🔨 Latest commit 10f1a68
🔍 Latest deploy log https://app.netlify.com/projects/rp-cloud/deploys/69f3ee77fe7e4900087d9672
😎 Deploy Preview https://deploy-preview-568--rp-cloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 30, 2026

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d2876730-2b71-4753-bb11-f49671b70298

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

The pull request updates documentation across three files to reflect changes in the Redpanda Cloud Security UI. Navigation paths are made more specific by directing users to discrete Security subpages—Security > Users for user creation, Security > ACLs for ACL configuration, and Security > Roles for role assignment—rather than referencing a generic Security page. Additionally, ACL setup instructions are rewritten to include explicit field-by-field configuration steps. A TODO marker is added to validate ACL form label names upon release of the new Security page.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested reviewers

  • mattschumpert
  • sago2k8
  • Feediver1
  • deniscoady
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically references the main change: updating Console ACL UI references to match the new atomic-ACL design across Cloud documentation pages.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The pull request description is comprehensive and well-structured, including a detailed summary, context links, page previews, and a test plan checklist.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch DOC-2123-console-acl-ui-refresh

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@modules/get-started/pages/cluster-types/create-dedicated-cloud-cluster.adoc`:
- Line 61: Remove the placeholder TODO marker "// TODO DOC-2123" and replace it
with the final, verified ACL field labels (or remove the comment entirely) once
you confirm the exact UI wording; specifically update the ACL labels to match
the UI values for Resource Type, Pattern Type, Resource Name, Operation,
Permission, and Host in the create-dedicated-cloud-cluster.adoc content, and
ensure no TODO markers remain before merge.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c92a7210-48b6-414c-9426-ee14325b4e06

📥 Commits

Reviewing files that changed from the base of the PR and between cad24bb and 6bfa49a.

📒 Files selected for processing (3)
  • modules/get-started/pages/cluster-types/create-dedicated-cloud-cluster.adoc
  • modules/get-started/pages/cluster-types/serverless.adoc
  • modules/security/pages/cloud-authentication.adoc

```

. Click the name of your user, and add the following permissions to the ACL (access control list):
// TODO DOC-2123: confirm final ACL form labels (Resource Type, Pattern Type, Resource Name, Operation, Permission, Host) once the new Security page ships.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Resolve TODO before merge to avoid label drift in GA docs.

Leaving // TODO DOC-2123 here means ACL field labels may ship unverified; this conflicts with the PR’s stated merge condition to resolve all TODO markers.

Based on learnings: “In Redpanda Cloud documentation, field names and labels should match exactly what appears in the UI, even if the terminology might seem technically inconsistent.”

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@modules/get-started/pages/cluster-types/create-dedicated-cloud-cluster.adoc`
at line 61, Remove the placeholder TODO marker "// TODO DOC-2123" and replace it
with the final, verified ACL field labels (or remove the comment entirely) once
you confirm the exact UI wording; specifically update the ACL labels to match
the UI values for Resource Type, Pattern Type, Resource Name, Operation,
Permission, and Host in the create-dedicated-cloud-cluster.adoc content, and
ensure no TODO markers remain before merge.

micheleRP and others added 5 commits April 30, 2026 17:18
Announce Console's redesigned Security page (atomic ACL list, role
detail pages with inherited ACLs, user detail pages, regex filter) in
the cloud-docs What's New. The blurb sits behind the same merge gate
as the rest of the PR so it only goes live with Console GA.

Inline TODO for Jan/Martin to confirm whether the customer-facing
"editing an ACL no longer causes a permission gap" benefit can be
stated publicly.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…alone

Previous commits referenced a standalone Security > ACLs page that
does not exist in the shipped Console build (per Jan's recorded demo).
The new layout has three tabs only — Users, Roles, Permissions — and
ACLs are managed from a principal's detail page.

- create-dedicated-cloud-cluster.adoc: rewrite the user/ACL walkthrough
  to follow the real flow: create the user, click "Go to user details"
  from the success dialog, then "+ Add ACL" under the user's ACLs
  section. Field labels match the Add ACL modal (Resource Type,
  Pattern Type, Resource Name, Operation, Permission, Host).
- serverless.adoc, cloud-authentication.adoc: drop the "Security > ACLs"
  path; route users through Users/Roles detail pages instead.
- whats-new-cloud.adoc: rewrite the May 2026 entry to describe the
  three-tab layout (Users / Roles / Permissions), per-principal ACL
  management on the detail page, and the three available actions
  (+ Add ACL, Allow all operations, Delete selected for bulk delete).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The third Security page tab is Permissions — a unified cluster-wide
view of every principal's ACLs (direct + inherited), with role
inheritance visualized as "VIA ROLE: <role-name>" groupings when you
expand a row. Add this and the deny-spot indicator to the What's New
blurb.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Preview-only playbook change so the cloud-docs Netlify preview pulls
single-sourced acl.adoc / rbac-dp.adoc / gbac-dp.adoc content from
docs PR #1689 instead of docs main. This lets reviewers see the
single-sourced rewrites in cloud-docs context before either PR merges.

REVERT (set documentation main branch back to first position) before
merge.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- Replace 2 em dashes with parentheses and split sentences.
- Tighten passive "ACLs are managed per principal" lead-in.
- Align "Allow all operations" caveat phrasing with acl.adoc.
- Reword regex example "for example" comma comma into a cleaner
  semicolon construction.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@micheleRP micheleRP requested review from jvorcak and weeco May 1, 2026 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant