test(client): add hash field subkey notifications test#3264
Open
nkaradzhov wants to merge 2 commits into
Open
Conversation
Verify that hash field expiration emits the expected subkey-level keyspace and keyevent notifications (hexpire/hexpired) on Redis 8.8+. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Make lint:changed pass on this branch: replace `as any` with a scoped `@ts-expect-error`, type `setImmediateStub` via `ReturnType<typeof stub>`, prefix unused destructured vars with `_`, and rewrite a generator spread with `forEach` to drop one editor-only TS2802 suppression. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verify that hash field expiration emits the expected subkey-level keyspace and keyevent notifications (hexpire/hexpired) on Redis 8.8+.
Description
Checklist
npm testpass with this change (including linting)?Note
Low Risk
Test-only changes that add a Redis 8.8+ PubSub/CONFIG-based integration test; minimal product risk, with the main risk being potential CI flakiness due to timing/event ordering.
Overview
Adds an integration test (Redis 8.8+ only) that verifies
HPEXPIREon a hash field emits the expected subkey-level keyspace/keyevent PubSub notifications (hexpire/hexpired) across the various__subkey*__channels, temporarily togglingnotify-keyspace-eventsand asserting received payloads.Also tightens a few TypeScript expectations/types in the client tests (e.g., explicit
@ts-expect-error, more specificRedisClientTypegenerics, and a typedsinon.stubhandle) without changing runtime behavior.Reviewed by Cursor Bugbot for commit 17fc01d. Bugbot is set up for automated code reviews on this repo. Configure here.