Skip to content

Fix incorrect rladmin command in create-certificates.md (fixes #3737) - #3807

Open
harshh6305 wants to merge 3 commits into
redis:mainfrom
harshh6305:fix/rladmin-certificates
Open

Fix incorrect rladmin command in create-certificates.md (fixes #3737)#3807
harshh6305 wants to merge 3 commits into
redis:mainfrom
harshh6305:fix/rladmin-certificates

Conversation

@harshh6305

@harshh6305 harshh6305 commented Aug 13, 2026

Copy link
Copy Markdown

Fixes #3737

Problem

The "Install certificates" section instructed users to check certificate status using:

   rladmin status certificates

This command doesn't work — rladmin has no certificates subcommand, resulting in:

   ERROR: invalid token 'certificates'

Fix

Replaced the incorrect command with an openssl x509 command to verify the installed certificate's expiration dates, as suggested in the issue.


Note

Low Risk
Documentation-only change to install/verify steps; no product code or security behavior is modified.

Overview
Fixes incorrect Install certificates guidance that told readers to run rladmin status certificates, which fails because rladmin has no certificates subcommand.

The post-install step is retitled to Verify the installed certificate and now uses openssl x509 against /etc/opt/redislabs/<cert-name>_cert.pem to show subject, issuer, and validity dates. The follow-on rladmin info cluster step for certificate details is removed so verification is a single, working command.

Reviewed by Cursor Bugbot for commit 401c8bb. Bugbot is set up for automated code reviews on this repo. Configure here.

@dwdougherty dwdougherty added the rs Redis Software label Aug 13, 2026

@kaitlynmichael kaitlynmichael left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes and then we can merge. Thanks!

Comment thread content/operate/rs/security/certificates/create-certificates.md Outdated
Comment thread content/operate/rs/security/certificates/create-certificates.md Outdated
openssl x509 -in /path/to/redis-cert-chain.pem -noout -dates
```

1. View certificate details:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also delete this step and its code block (lines 606–610)? rladmin info cluster prints cluster policies and tunables — repl_diskless, slave_ha, login_lockout_threshold — and no certificate data at all, so it can't show certificate details. It came in with the same commit as rladmin status certificates, so it's the same bug. The openssl command above already covers what this step was reaching for via -subject -issuer -dates.

harshh6305 and others added 2 commits August 14, 2026 12:24
Co-authored-by: Kaitlyn Michael <76962844+kaitlynmichael@users.noreply.github.com>
@harshh6305

Copy link
Copy Markdown
Author

@kaitlynmichael Thanks for the review! I've made all the requested changes
Updated the command to include -subject -issuer with the correct cert path
Updated the heading to "Verify the installed certificate:"
Removed the invalid "View certificate details" step (rladmin info cluster)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rs Redis Software

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feedback: Create certificates

3 participants