RI-8278 i18n: migrate keyboard shortcuts - #6404
Open
valkirilov wants to merge 3 commits into
Open
Conversation
MAC_SHORTCUTS and COMMON_SHORTCUTS repeated the same 13 shortcuts, diverging only in the rendered key symbols and two descriptions that turned out to be unintentional (Run Command/Commands, a stray colon on the RDI editor shortcut). Merging them into one object keyed by isMac removes the duplication and the dead label field. References: RI-8278
Resolves the last hardcoded English in constants/keyboardShortcuts.tsx. Also translates the shortcuts drawer's own chrome (title, column headers, group headings), which the description cell renderer already had to touch. References: RI-8278
Contributor
Code Coverage - Frontend unit tests
Test suite run success8032 tests passing in 871 suites. Report generated by 🧪jest coverage report action from 238ca72 |
…hover Автоматично дописване is the accepted Bulgarian term for autocomplete, not Автодовършване. Also add a title attribute to the shortcuts description cell so truncated text is readable on hover.
VaskoAtanasovRedis
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Third and last of 3 PRs for RI-8278. Stacked on #6403 — only the last two commits are new here.
keyboardShortcuts.tsx: it had two near-identical copies of the shortcut list (one for macOS, one for everything else). Merged into one.Two small wording changes on macOS only, worth a second look:
Stack
Test plan
Note
Low Risk
UI/i18n-only changes with no auth, security, or data-handling impact. Main risk is missing translation keys or unintended Mac vs non-Mac copy differences after the merge.
Overview
Makes keyboard shortcut UI copy translatable and cleans up the shortcut definitions.
Merges the duplicated Mac/non-Mac lists in
keyboardShortcuts.tsxinto oneKEYBOARD_SHORTCUTSobject with platform-conditional keys. Shortcut entries now storedescriptionKeyinstead of hardcoded Englishdescriptiontext.Wires i18n through the shortcuts drawer (title, column headers, group names, and all descriptions) and the RDI job page dedicated-editor tooltip. Adds matching
shortcuts.*keys toen.jsonandbg.json.Also unifies two small wording inconsistencies: Workbench run text to "Run Command", and removes a stray trailing colon from the RDI editor shortcut description.
Reviewed by Cursor Bugbot for commit 238ca72. Bugbot is set up for automated code reviews on this repo. Configure here.