Page size mismatch

[malucius-rh]

Description

This resolves a failure in the "--page_size" option to validate due to the lack of the underscore in the option handling case statement. Since the intent of the option is to set the minimum file size for auto mode the ultimate resolution is to rename the option to min_file_size (which pairs well with the existing max_file_size)

Documentation is updated to reflect the changed option name

Before/After Comparison

Before: Using --page_size results in an option validation error in the option handling case statement due to a missing underscore
After: --page_size is replaced by the more accurately named --min_page_size and is handled properly

Clerical Stuff

This closes #67
JIRA: RPOPC-1242
Extract from raw results file using --min_page_size 4096

        Output is in kBytes/sec
        Time Resolution = 0.000001 seconds.
        Processor cache size set to 1024 kBytes.
        Processor cache line size set to 32 bytes.
        File stride size set to 17 * record size.
                                                                    random    random      bkwd     record     stride                                        
              kB  reclen    write    rewrite      read    reread      read     write      read    rewrite       read    fwrite  frewrite     fread   freread
            4096       1    709771    895680   1727521   1739415   1184099    726611   1161916     769921    1173263    759505    759908   1678081   1680872
            4096       2   1238206   1704384   3310948   3279348   2316655   1382373   2269226    1517682    2298370   1397895   1396078   2765680   2773270

Extract from raw result allowing default to be used:

      Using minimum file size of 1024 kilobytes.
        Using maximum file size of 4194304 kilobytes.
        Using Minimum Record Size 1 kB
        Using Maximum Record Size 1024 kB
        Command line used: /usr/bin/iozone -az -f /iozone/iozone01/iozone-xfs -n 1024k -g 4096m -y 1k -q 1m /iozone/iozone/iozone1
        Output is in kBytes/sec
        Time Resolution = 0.000001 seconds.
        Processor cache size set to 1024 kBytes.
        Processor cache line size set to 32 bytes.
        File stride size set to 17 * record size.
                                                                    random    random      bkwd     record     stride                                        
              kB  reclen    write    rewrite      read    reread      read     write      read    rewrite       read    fwrite  frewrite     fread   freread
            1024       1    686776    902340   1729884   1723636   1196434    725770   1154621     762491    1131503    733454    776413   1687075   1456510
            1024       2   1130312   1568189   3369115   3369115   2337008   1275301   2178189    1408737    2343383   1370965   1380217   2813041   2827858

[coderabbitai]

Warning

Review limit reached

@malucius-rh, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 41 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 8eb5ebbd-96dd-43c8-97db-bdeac76076af

📥 Commits

Reviewing files that changed from the base of the PR and between c5b77e3 and 2e259af.

📒 Files selected for processing (2)

• README.md
• iozone/iozone_run.sh

📝 Walkthrough

Summary by CodeRabbit

• New Features

  • Renamed the minimum file-size command-line option to --min_file_size.
  • Updated help text and automatic and throughput modes to use the renamed option.
  • Preserved the default minimum file size of 1024 KB.

• Documentation

  • Updated the README to document --min_file_size instead of the previous option name.

Walkthrough

The CLI option and internal setting were renamed from page_size to min_file_size. Documentation, parsing, defaults, system information, throughput commands, and automatic-mode test arguments now use the new name.

Changes

Minimum file size option rename

Layer / File(s)	Summary
CLI contract and parsing README.md, iozone/iozone_run.sh	The documented option, default variable, usage text, accepted argument list, and argument parser now use min_file_size.
Execution setting propagation iozone/iozone_run.sh	Throughput commands, automatic-mode test arguments, and system information now use min_file_size.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: sayalibhavsar

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Linked Issues check	⚠️ Warning	The PR supports the issue's intent under --min_file_size, but it does not implement #67's specified --page_size fix.	Retain and fix --page_size as specified by #67, or update the issue to explicitly approve the breaking rename to --min_file_size.
Out of Scope Changes check	⚠️ Warning	Renaming the public option to --min_file_size changes the interface beyond #67, which requests repairing --page_size; the documentation update is related.	Limit the change to fixing --page_size, or document and approve the CLI rename as a separate requirement.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title is concise and clearly identifies the page-size handling issue addressed by the pull request.
Description check	✅ Passed	The description includes the required summary, comparison, issue closure, and JIRA reference, but it incorrectly names the new option as --min_page_size.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Create stacked PR
• Commit on current branch

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@iozone/iozone_run.sh`:
- Around line 683-684: Separate the manual-mode record-size value from
min_file_size in the throughput command around ioZone execution: add a dedicated
option/variable for the -r argument, while keeping min_file_size exclusively as
auto mode’s minimum file-size setting used by the existing -n and reporting
paths. Update the wrapper’s option parsing and documentation/help text so the
new record-size behavior is explicit.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7d767ae9-f7c6-4896-be85-9d3a1e800ede

📥 Commits

Reviewing files that changed from the base of the PR and between b1b40a0 and c5b77e3.

📒 Files selected for processing (2)

• README.md
• iozone/iozone_run.sh