fix(lightspeed-mcp): refactored mcp config modal#3698
Conversation
|
Important This PR includes changes that affect public-facing API. Please ensure you are adding/updating documentation for new features or behavior. Changed Packages
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3698 +/- ##
==========================================
+ Coverage 54.59% 54.92% +0.33%
==========================================
Files 2361 2362 +1
Lines 90132 90451 +319
Branches 25214 25342 +128
==========================================
+ Hits 49205 49680 +475
+ Misses 40645 40487 -158
- Partials 282 284 +2
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
HusneShabbir
left a comment
There was a problem hiding this comment.
Hey @ciiay , I have a couple of questions:
-
Why haven't we implemented the "forget token" action? Without it, disconnecting an MCP feels a bit bizarre. I also noticed it's explicitly mentioned as the third point in the RHIDP-14843 description.
-
Would it be possible to eliminate the UI flicker that's happening when toggling the MCP on/off?
-
I also noticed that when the toggle is turned off, the status shown in the panel doesn't change. That doesn't seem to match the behavior shown in the prototype.
Also, from a UX perspective, I think the Save button should become enabled whenever the user changes the toggle or token. Right now, the changes seem to take effect immediately, leaving Cancel as the only meaningful action, which was a bit confusing to me as a first-time user.
cc: @ShiranHi
Screen.Recording.2026-07-08.at.5.09.34.PM.mov
2e456d9 to
6c03c52
Compare
|
Hi @HusneShabbir , thanks for the review. Here's some background from previous discussion.
It's implemented as "Remove personal token" and hidden for MCP servers that doesn't have a personal token input yet.
Good catch, fixed in my new commit.
Addressed in my new commit 🤝 |
HusneShabbir
left a comment
There was a problem hiding this comment.
Tested all the edge cases locally.
/lgtm
FYI: I'll cover the E2E tests for this implementation in RHIDP-15136.
|
New changes are detected. LGTM label has been removed. |
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
a253f7c to
7417c68
Compare
Signed-off-by: Yi Cai <yicai@redhat.com>
Instead of approve he he selected request changes,
Signed-off-by: Yi Cai <yicai@redhat.com>
HusneShabbir
left a comment
There was a problem hiding this comment.
Everything looks good to me. Thanks for addressing my review feedback!
I do have one observation, though: shouldn't the status of the DCR-authenticated MCP server match exactly what is shown in the sidebar?
Why does it show "Token required" even when the server is connected?
Screen.Recording.2026-07-13.at.10.55.30.PM.mov
Signed-off-by: Yi Cai <yicai@redhat.com>
|
Hi @HusneShabbir , thanks for the review.
This is the DCR auth flow that was not covered in my previous code changes. I have added fix for this flow in my latest commit. Can you take another look? |
|



Hey, I just made a Pull Request!
For RHIDP-14843
Refactor the MCP server configure modal with PatternFly layout and improved credential management:
@patternfly/react-coreto 6.6.0 and add translations for new modal strings (de, es, fr, it, ja)The backend now exposes
hasOrgTokenon MCP server list and patch responses so the UI can distinguish organization default tokens from personal-only servers.Behavior confirmation: Intelligent-assistant MCP config modal details alignment
✔️ Checklist
Test steps:
Test steps for Intelligent-assistant plugin
screen recording(updated on 7/13)
rhidp_14834.mp4