feat(app-auth): Make signInPage config optional and derive from auth providers#3286
Open
JessicaJHee wants to merge 1 commit into
Open
feat(app-auth): Make signInPage config optional and derive from auth providers#3286JessicaJHee wants to merge 1 commit into
JessicaJHee wants to merge 1 commit into
Conversation
JessicaJHee
requested review from
a team,
christoph-jerolimov and
rohitkrai03
as code owners
|
Important This PR includes changes that affect public-facing API. Please ensure you are adding/updating documentation for new features or behavior. Changed Packages
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3286 +/- ##
=======================================
Coverage 53.92% 53.92%
=======================================
Files 2379 2379
Lines 86125 86125
Branches 23915 23915
=======================================
Hits 46441 46441
Misses 38175 38175
Partials 1509 1509
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
gashcrumb
reviewed
Jun 4, 2026
…providers Signed-off-by: Jessica He <jhe@redhat.com>
JessicaJHee
force-pushed
the
optional-signinpage
branch
from
e107552 to
2c59e28
Compare
|
gashcrumb
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
signInPageconfig optionalauth.providers(excluding guest), falling back to GitHub if none are configuredsignInPageconfig still overrides the list and maintains previous behaviour.Fixes RHIDP-13492
✔️ Checklist