chore(scorecard): version bump to v1.51.0#3284
Conversation
|
Important This PR includes changes that affect public-facing API. Please ensure you are adding/updating documentation for new features or behavior. Changed Packages
|
ReviewFindingsLow
Info
Previous runReviewFindingsLow
Info
Previous run (2)ReviewFindingsMedium
Low
Info
Previous run (3)ReviewFindingsHigh
Low
Info
Previous run (4)ReviewReason: stale-head The review agent reviewed commit Previous run (5)ReviewReason: stale-head The review agent reviewed commit |
| '@red-hat-developer-hub/backstage-plugin-scorecard': minor | ||
| --- | ||
|
|
||
| Backsatge version bump to v1.51.0 |
There was a problem hiding this comment.
[low] naming-convention
Typo in changeset description: 'Backsatge version bump to v1.51.0' should be 'Backstage version bump to v1.51.0'. This text will appear in the published changelog.
Suggested fix: Fix the typo: Backsatge → Backstage.
4b5264d to
1cd6c9b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3284 +/- ##
=======================================
Coverage 53.93% 53.93%
=======================================
Files 2379 2379
Lines 86166 86166
Branches 23916 23915 -1
=======================================
Hits 46476 46476
Misses 39385 39385
Partials 305 305
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
1cd6c9b to
6b6556b
Compare
|
|
||
| const displayName = getLocaleDisplayName(locale); | ||
| await this.page.getByRole('link', { name: 'Settings' }).click(); | ||
| await this.page.goto('/settings'); |
There was a problem hiding this comment.
[low] test-inadequate
E2E test replaced UI-element-based navigation with direct page.goto() calls, slightly reducing coverage of navigation link presence/functionality. The affected code is test setup, not the behavior under test.
6b6556b to
aad1405
Compare
|
|
|
||
| const displayName = getLocaleDisplayName(locale); | ||
| await this.page.getByRole('link', { name: 'Settings' }).click(); | ||
| await this.page.goto('/settings'); |
There was a problem hiding this comment.
[low] test-weakened
switchToLocale switches from role-based link clicking to direct URL navigation (page.goto), bypassing UI element verification. However, this is consistent with existing page.goto() usage in loginAndSetLocale() and openCatalog() in the same file, and the method's core purpose (locale switching) remains fully tested.



Hey, I just made a Pull Request!
Scorecard version bump
Fix - https://redhat.atlassian.net/browse/RHIDP-13795
Screen.Recording.2026-06-03.at.8.55.19.PM.mov
How to test
app-config.yamlapp-config.yamlapp-config.yaml✔️ Checklist