Skip to content

feat: add boost workspace scaffold#3259

Merged
durandom merged 8 commits into
redhat-developer:mainfrom
durandom:add-boost-workspace
Jun 2, 2026
Merged

feat: add boost workspace scaffold#3259
durandom merged 8 commits into
redhat-developer:mainfrom
durandom:add-boost-workspace

Conversation

@durandom
Copy link
Copy Markdown
Member

@durandom durandom commented Jun 1, 2026

Summary

  • Scaffolds the boost workspace — a rewrite of the augment plugin
  • Adds workspace configuration files mirroring augment's structure (package.json, tsconfig, app-config, changeset config, etc.)
  • Registers @durandom and @gabemontero as CODEOWNERS for /workspaces/boost

This is the initial workspace-only PR per CONTRIBUTING.md guidelines — plugin code will follow in subsequent PRs.

Test plan

  • CI passes on the workspace scaffold
  • CODEOWNERS validates (maintainers are members of the GitHub org)
  • yarn install succeeds in the workspace

🤖 Generated with Claude Code

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 1, 2026

This pull request adds a new top-level directory under workspaces/. Please follow Submitting a Pull Request for a New Workspace in CONTRIBUTING.md.

@rhdh-gh-app
Copy link
Copy Markdown

rhdh-gh-app Bot commented Jun 1, 2026

⚠️ CODEOWNERS Validation Failed

The following users are listed in CODEOWNERS but are not members of the rhdh-plugins-codeowners team:

durandom

An org admin needs to add the missing members to the team before this PR can be merged.

1 similar comment
@rhdh-gh-app
Copy link
Copy Markdown

rhdh-gh-app Bot commented Jun 1, 2026

⚠️ CODEOWNERS Validation Failed

The following users are listed in CODEOWNERS but are not members of the rhdh-plugins-codeowners team:

durandom

An org admin needs to add the missing members to the team before this PR can be merged.

Copy link
Copy Markdown
Contributor

@gabemontero gabemontero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I checked out your PR locally @durandom and got an error doing a yarn install

gmontero ~/go/src/github.com/redhat-developer/rhdh-plugins/workspaces/boost  (local-upstream-3259-copy)$ yarn install 
Usage Error: The nearest package directory (/home/gmontero/go/src/github.com/redhat-developer/rhdh-plugins/workspaces/boost) doesn't seem to be part of the project declared in /home/gmontero/go/src/github.com/redhat-developer/rhdh-plugins.

- If /home/gmontero/go/src/github.com/redhat-developer/rhdh-plugins isn't intended to be a project, remove any yarn.lock and/or package.json file there.
- If /home/gmontero/go/src/github.com/redhat-developer/rhdh-plugins is intended to be a project, it might be that you forgot to list workspaces/boost in its workspace configuration.
- Finally, if /home/gmontero/go/src/github.com/redhat-developer/rhdh-plugins is fine and you intend workspaces/boost to be treated as a completely separate project (not even a workspace), create an empty yarn.lock file in it.

$ yarn install [--json] [--immutable] [--immutable-cache] [--refresh-lockfile] [--check-cache] [--check-resolutions] [--inline-builds] [--mode #0]
gmontero ~/go/src/github.com/redhat-developer/rhdh-plugins/workspaces/boost  (local-upstream-3259-copy)$ git log -2
commit fdaf93e26db0501772514eef4cb33c6bcfa0abeb (HEAD -> local-upstream-3259-copy)
Author: Marcel Hild <hild@b4mad.net>
Date:   Mon Jun 1 16:06:06 2026 +0200

    chore: remove non-scaffolder files from boost workspace
    
    Keep only files that the workspace scaffolder would generate.
    Additional config files can be added as needed during plugin development.
    
    Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

commit 81d0111df31adbebaf211ff4e732d1dd31191cb7
Author: Marcel Hild <hild@b4mad.net>
Date:   Mon Jun 1 15:58:09 2026 +0200

    feat: add boost workspace scaffold
    
    Boost is a rewrite of the augment plugin. This initial PR establishes the
    workspace structure and CODEOWNERS so maintainers have full autonomy for
    subsequent plugin development.
    
    Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gmontero ~/go/src/github.com/redhat-developer/rhdh-plugins/workspaces/boost  (local-upstream-3259-copy)$ 

not sure if something is missing from the skill you used, or the yarn new invocation you did, etc.

once we get this sorted, I'm interested in adding a script to package.json to allow for running in the debugger, but I first want to compare the later versions of backstage-cli with the older ways we used to use yarn to do this

thanks

@durandom durandom marked this pull request as ready for review June 2, 2026 09:03
@durandom durandom requested review from a team as code owners June 2, 2026 09:03
Copilot AI review requested due to automatic review settings June 2, 2026 09:03
@durandom durandom requested a review from a team as a code owner June 2, 2026 09:03
durandom and others added 3 commits June 2, 2026 11:04
Boost is a rewrite of the augment plugin. This initial PR establishes the
workspace structure and CODEOWNERS so maintainers have full autonomy for
subsequent plugin development.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Keep only files that the workspace scaffolder would generate.
Additional config files can be added as needed during plugin development.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Without a yarn.lock, Yarn walks up to the root package.json and fails
because boost isn't listed in a root workspaces field.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@durandom durandom force-pushed the add-boost-workspace branch from adbc7be to ce1ec8f Compare June 2, 2026 09:04
@durandom
Copy link
Copy Markdown
Member Author

durandom commented Jun 2, 2026

@gabemontero Good catch! The issue was a missing yarn.lock file — I scaffolded the workspace manually instead of using yarn create-workspace (which wasn't available in my shell), and missed that the scaffolder template ships an empty yarn.lock with # intentionally left empty. Yarn Berry needs that file to treat each workspace as an independent project boundary.

Fixed in the latest push (commit ce1ec8f) — also rebased onto latest main to resolve the CODEOWNERS conflict. Should work now:

cd workspaces/boost
yarn install

Re: the debugger script — sounds good, happy to add that once we figure out the right approach for the current backstage-cli version.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an initial scaffold for a new workspaces/boost workspace (intended as a rewrite of the existing augment workspace) and wires up ownership in CODEOWNERS.

Changes:

  • Adds the initial workspaces/boost workspace config files (package/tsconfig/Backstage metadata/changesets config).
  • Adds Boost workspace documentation (README.md) and catalog metadata (catalog-info.yaml).
  • Registers /workspaces/boost code owners in .github/CODEOWNERS.

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
workspaces/boost/yarn.lock Adds a workspace lockfile placeholder (currently empty).
workspaces/boost/package.json Introduces workspace scripts and devDependencies for Backstage repo tooling.
workspaces/boost/tsconfig.json Sets TypeScript config for packages/plugins paths in the workspace.
workspaces/boost/README.md Documents workspace purpose and common development commands.
workspaces/boost/catalog-info.yaml Registers the workspace as a Backstage catalog Component.
workspaces/boost/backstage.json Pins the Backstage version for the workspace.
workspaces/boost/.changeset/config.json Adds Changesets configuration for the workspace.
.github/CODEOWNERS Adds code ownership rules for /workspaces/boost.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +28 to +33
"workspaces": {
"packages": [
"packages/*",
"plugins/*"
]
},
Comment on lines +3 to +6
This workspace contains the Boost plugin family for Red Hat Developer Hub.

Boost is a rewrite of the [Augment](../augment/) plugin.

@durandom
Copy link
Copy Markdown
Member Author

durandom commented Jun 2, 2026

@gabemontero If you're happy with the fix, let's get this merged as-is. Per CONTRIBUTING.md, the initial PR should just establish the workspace and CODEOWNERS — that way we have merge permissions and can iterate on plugin code in follow-up PRs without needing rhdh-cope approval each time.

durandom and others added 4 commits June 2, 2026 11:19
CI runs yarn install --immutable which requires a fully resolved lockfile.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
tsc fails with TS18003 when include globs match zero files.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When both files and include are specified, tsc accepts empty include
globs without erroring. Restored include paths for when plugins are added.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.57%. Comparing base (03ef10a) to head (f30615c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3259   +/-   ##
=======================================
  Coverage   53.57%   53.57%           
=======================================
  Files        2407     2407           
  Lines       86524    86524           
  Branches    23952    23952           
=======================================
  Hits        46358    46358           
  Misses      38611    38611           
  Partials     1555     1555           
Flag Coverage Δ *Carryforward flag
adoption-insights 83.58% <ø> (ø) Carriedforward from 4fb7699
ai-integrations 70.03% <ø> (ø) Carriedforward from 4fb7699
app-defaults 69.60% <ø> (ø) Carriedforward from 4fb7699
augment 46.39% <ø> (ø) Carriedforward from 4fb7699
bulk-import 72.86% <ø> (ø) Carriedforward from 4fb7699
cost-management 16.49% <ø> (ø) Carriedforward from 4fb7699
dcm 45.40% <ø> (ø) Carriedforward from 4fb7699
extensions 61.79% <ø> (ø) Carriedforward from 4fb7699
global-floating-action-button 74.30% <ø> (ø) Carriedforward from 4fb7699
global-header 61.63% <ø> (ø) Carriedforward from 4fb7699
homepage 51.52% <ø> (ø) Carriedforward from 4fb7699
konflux 91.01% <ø> (ø) Carriedforward from 4fb7699
lightspeed 68.33% <ø> (ø) Carriedforward from 4fb7699
mcp-integrations 85.46% <ø> (ø) Carriedforward from 4fb7699
orchestrator 36.61% <ø> (ø) Carriedforward from 4fb7699
quickstart 62.88% <ø> (ø) Carriedforward from 4fb7699
sandbox 79.56% <ø> (ø) Carriedforward from 4fb7699
scorecard 83.84% <ø> (ø) Carriedforward from 4fb7699
theme 64.54% <ø> (ø) Carriedforward from 4fb7699
translations 8.49% <ø> (ø) Carriedforward from 4fb7699
x2a 78.79% <ø> (ø) Carriedforward from 4fb7699

*This pull request uses carry forward flags. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03ef10a...f30615c. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

CI's ensure-clean-working-directory step fails because yarn install
creates .yarn/ which isn't gitignored.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 2, 2026

@durandom durandom merged commit 93705f9 into redhat-developer:main Jun 2, 2026
68 checks passed
@durandom durandom deleted the add-boost-workspace branch June 2, 2026 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants