fix(orchestrator): detect GitHub SAML SSO session expiry and prompt users to re-authorize#3253
Conversation
6776cee to
462448f
Compare
Changed Packages
|
6c068e2 to
1428c7e
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3253 +/- ##
==========================================
+ Coverage 53.29% 53.33% +0.04%
==========================================
Files 2407 2408 +1
Lines 86420 86514 +94
Branches 23957 23978 +21
==========================================
+ Hits 46056 46142 +86
- Misses 38887 38895 +8
Partials 1477 1477
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
lokanandaprabhu
left a comment
There was a problem hiding this comment.
@karthikjeeyar , Working as expected, I will approve when local testing piece is removed from PR
85ca52a to
12962bd
Compare
|
…3264, #3253) (#3270) * fix(orchestrator-form): evaluate conditional ui:hidden with scoped form data Evaluate sibling when paths against the current object/step form data so conditionally hidden fields show and hide correctly in wizards. Fix the review step toggle by iterating schema properties when including hidden fields and applying the same scoped condition evaluation. Co-authored-by: Cursor <cursoragent@cursor.com> * chore(orchestrator): add changeset for scoped conditional ui:hidden fix Co-authored-by: Cursor <cursoragent@cursor.com> * chore(orchestrator): clarify changeset for conditional hidden fields fix Co-authored-by: Cursor <cursoragent@cursor.com> * fix(orchestrator): restore status and date filters on workflow runs Filtering workflow runs by status or date failed after query variables were introduced. Use the correct filter types so results load instead of showing an error. Co-authored-by: Cursor <cursoragent@cursor.com> * feat(orchestrator-form): hide wizard steps for conditional ui:hidden Evaluate conditional ui:hidden when filtering wizard steps using scoped form data and root fallbacks, align validation with visible steps, and add isNotEmptyList/notContains operators with unit tests. Co-authored-by: Cursor <cursoragent@cursor.com> * chore(orchestrator-form): update API reports for HiddenCondition operators Co-authored-by: Cursor <cursoragent@cursor.com> * chore(orchestrator): revert unrelated report-alpha.api.md ordering change Co-authored-by: Cursor <cursoragent@cursor.com> * Update workspaces/orchestrator/.changeset/conditional-step-hiding-operators.md Co-authored-by: Karthik Jeeyar <karthik@redhat.com> * detect GitHub SAML SSO session expiry and prompt users to re-authorize --------- Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Karthik Jeeyar <karthik@redhat.com> Co-authored-by: Karthik <karthik.jk11@gmail.com>



Hey, I just made a Pull Request!
Fixes: https://redhat.atlassian.net/browse/RHDHBUGS-3216
Changes included in this PR:
x-github-ssoresponse header when availableScreenshots:
How to Test:
Create these workflow and schema files:
packages/backend/.devModeTemp/repository/workflows/github-sso-test.sw.yamlpackages/backend/.devModeTemp/repository/workflows/schemas/github-sso-test-input-schema.jsonstart the application using
yarn devSet the simulate sso variable in localstorage
localStorage.setItem('SIMULATE_SAML_SSO_ERROR', true)Execute the
Github SSO Testworkflow by visiting http://localhost:3000/orchestrator/workflows/github-sso-test/executeNOTE:
SIMULATE_SAML_SSO_ERRORlogic is only added for the testing purpose, I will remove this before merging it.✔️ Checklist