chore: generalize release-1.* branch patterns for 2.y support#3189
Draft
polasudo wants to merge 1 commit into
Draft
chore: generalize release-1.* branch patterns for 2.y support#3189polasudo wants to merge 1 commit into
polasudo wants to merge 1 commit into
Conversation
GitHub Actions branch filters and Renovate baseBranchPatterns hardcoded release-1.[0-9]+ / rhdh-1.[0-9]+ / 1.[0-9]+.x, which would silently stop matching once release branches move to release-2.0 and beyond. Generalize these to digit-agnostic patterns (release-[0-9]+.[0-9]+, etc.) so CI keeps working across the 1.y -> 2.y transition with no further changes needed. Part of the upstream build-infrastructure audit for 2.y readiness. Co-authored-by: Cursor <cursoragent@cursor.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release-1.[0-9]+/rhdh-1.[0-9]+/1.[0-9]+.xbranch-filter patterns in GitHub Actions workflows and Renovate config to digit-agnostic equivalents (release-[0-9]+.[0-9]+, etc.), so CI/Renovate continue to trigger correctly once release branches move torelease-2.0and beyond.1.ybranches — verified via regex simulation that the new patterns match both currentrelease-1.10-style branches and futurerelease-2.0/release-10.3-style branches, while still rejecting unrelated branches.Files changed
.github/workflows/pr.yaml.github/workflows/pr-dockerbuild-validation.yaml.github/workflows/pr-bundle-diff-checks.yaml.github/workflows/update-rpm-lockfile.yaml.github/workflows/next-container-build.yaml.github/renovate.jsonContext
Part of a broader upstream build-infrastructure audit for 2.y readiness across
rhdh-operator,rhdh-chart,rhdh-local, andred-hat-developers-documentation-rhdh. Opened as draft to track review before the 2.0 branch cut.Not included in this PR (flagged as follow-ups)
refs/heads/release-*), mirroringrhdh/rhdh-plugin-export-overlays.nightly.yaml,nightly-upgrade-test.yaml,sync-lightspeed-configs.yaml) and RenovatematchBaseBranchesdisable blocks for specific old branches — these are intentionally curated and get a normal manual update at every release cut.Test plan
release-1.ytriggersAssisted-by Cursor