perf(scripts): speed up RHDH operator install using install-rhdh-catalog-source.sh (~30 min → ~2 min) by subhashkhileri · Pull Request #2870 · redhat-developer/rhdh-operator

subhashkhileri · 2026-05-20T08:11:40Z

JIRA : https://redhat.atlassian.net/browse/RHIDP-13676

Summary

Skips slow skopeo inspect (~42s/bundle) — attempts the copy directly; failed copies (~3s) are faster than successful inspects, so images that don't exist on quay are handled with minimal overhead
Parallel bundle processing with MAX_PARALLEL=10 (env-overridable)
Parallel opm render + registry setup — these two phases are independent, so they now run concurrently; bundle processing waits until both are done
Atomic render.yaml updates — each worker writes a per-bundle .sed file (keyed by digest, no locking needed); all replacements are applied in a single sed -f pass after all workers complete
--ignore-not-found replaces the check-then-delete secret pattern
Force OLM re-index by deleting the CatalogSource before recreating it — without this, OLM skips re-indexing when the tag is unchanged but the image digest changed (rebuilt IIB)
Fail loudly if any bundle fails to process (was: silent error log + continue)

Assisted-by: Claude Code

- Skips slow `skopeo inspect` (~42s/bundle) — attempts the copy directly instead; failed copies (~3s) are faster than successful inspects - Processes bundles in parallel up to MAX_PARALLEL (default 10), with a portable kill-0 throttle loop that prunes finished PIDs each iteration - Collects per-worker sed files and applies them in one pass after all bundles complete, avoiding concurrent writes to render.yaml - Runs `opm render` and cluster registry setup in parallel since they are independent; waits before the bundle-processing phase begins - Replaces check-then-delete secret pattern with --ignore-not-found - Deletes existing CatalogSource before recreating to force OLM re-index when the tag is unchanged but the digest has changed (rebuilt IIB) - Fails loudly if any bundle fails to process (was: silent error log) Assisted-by: Claude Code Co-Authored-By: Claude Code <noreply@anthropic.com>

rhdh-qodo-merge · 2026-05-20T08:14:47Z

Review Summary by Qodo

(Agentic_describe updated until commit `49ef790`)

Parallelize IIB bundle processing for ~13x speedup

✨ Enhancement 🐞 Bug fix

Walkthroughs

Description

• Parallelize bundle processing with configurable MAX_PARALLEL (default 10)
  - Skips slow skopeo inspect (~42s/bundle); attempts copy directly instead
  - Processes bundles concurrently with portable kill-0 throttle loop
  - Collects per-worker sed files; applies replacements in single pass
• Run opm render and registry setup concurrently (independent phases)
• Force OLM re-index by deleting CatalogSource before recreation
• Improve error handling and debugging
  - Add set -euo pipefail to process_bundle function
  - Preserve skopeo stderr to per-bundle files for troubleshooting
  - Fail loudly if any bundle fails (was silent error log)
  - Validate MAX_PARALLEL is positive integer
• Simplify secret deletion with --ignore-not-found flag

Diagram

flowchart LR
  A["Extract bundle images"] --> B["Parallel bundle processing<br/>MAX_PARALLEL=10"]
  A --> C["opm render"]
  A --> D["Registry setup"]
  B --> E["Collect sed files"]
  C --> F["Wait for completion"]
  D --> F
  E --> G["Apply replacements<br/>single sed pass"]
  F --> G
  G --> H["Delete CatalogSource"]
  H --> I["Recreate CatalogSource<br/>force OLM re-index"]

File Changes

1. .rhdh/scripts/install-rhdh-catalog-source.sh Enhancement, bug fix, error handling +121/-48

Parallelize bundle processing and improve error handling

• Add MAX_PARALLEL environment variable with validation (default 10)
• Extract bundle processing logic into new process_bundle() function with set -euo pipefail
• Refactor update_refs_in_iib_bundles() to spawn parallel workers with portable throttle loop
• Collect per-bundle sed commands and apply atomically in single pass after all workers complete
• Run render_iib and registry setup concurrently; wait for both before bundle processing
• Replace check-then-delete secret pattern with --ignore-not-found flag
• Delete existing CatalogSource before recreation to force OLM re-indexing on digest changes
• Preserve skopeo stderr to per-bundle .copy.err files for debugging
• Add error handling to fail loudly if any bundle worker fails
• Update trap to kill background processes on EXIT/INT/TERM
• Remove unused variable declarations and simplify comments

.rhdh/scripts/install-rhdh-catalog-source.sh

…opeo stderr Background subshells don't inherit set -e from the parent, so intermediate failures (umoci, skopeo push) went undetected and the worker would write a .sed entry for a broken bundle. Also redirect speculative copy stderr to a per-bundle file instead of /dev/null so auth failures, timeouts, and disk errors are debuggable. Assisted-by: Claude Code Co-Authored-By: Claude Code <noreply@anthropic.com>

Assisted-by: Claude Code Co-Authored-By: Claude Code <noreply@anthropic.com>

rhdh-qodo-merge · 2026-05-25T08:19:01Z

Persistent review updated to latest commit 49ef790

…cess group kill 0 sends SIGTERM to the entire process group including the parent shell/CI harness, causing segfaults on normal exit. Use jobs -p to target only this script's background jobs. Split INT/TERM from EXIT to avoid re-entrant cleanup. Assisted-by: Claude Code Co-Authored-By: Claude Code <noreply@anthropic.com>

sonarqubecloud · 2026-05-28T05:33:04Z

Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

rm3l

Thanks @subhashkhileri !!

rm3l · 2026-05-28T07:38:19Z

/override "PR Publish"
/override "PR Validate"

unrelated

openshift-ci · 2026-05-28T07:38:24Z

@rm3l: Overrode contexts on behalf of rm3l: PR Publish, PR Validate

Details

In response to this:

/override "PR Publish"
/override "PR Validate"

unrelated

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

rm3l · 2026-05-28T10:29:07Z

/cherry-pick release-1.10

Just as a reminder to backport to 1.10 once 1.10.0 is out.

openshift-cherrypick-robot · 2026-05-28T10:29:49Z

@rm3l: new pull request created: #2913

Details

In response to this:

/cherry-pick release-1.10

Just as a reminder to backport to 1.10 once 1.10.0 is out.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

subhashkhileri requested a review from a team as a code owner May 20, 2026 08:11

subhashkhileri temporarily deployed to internal May 20, 2026 08:11 — with GitHub Actions Inactive

openshift-ci Bot requested review from gazarenkov and zdrapela May 20, 2026 08:11

subhashkhileri changed the title ~~perf(scripts): parallelize IIB bundle processing (~27 min → ~5 min)~~ perf(scripts): parallelize IIB bundle processing (~27 min → ~2 min) May 20, 2026

subhashkhileri changed the title ~~perf(scripts): parallelize IIB bundle processing (~27 min → ~2 min)~~ perf(scripts): parallelize IIB bundle processing (~30 min → ~2 min) May 20, 2026

rhdh-qodo-merge Bot added enhancement New feature or request Other labels May 20, 2026

subhashkhileri changed the title ~~perf(scripts): parallelize IIB bundle processing (~30 min → ~2 min)~~ erf(scripts): speed up RHDH operator cluster install (~30 min → ~2 min) May 20, 2026

subhashkhileri changed the title ~~erf(scripts): speed up RHDH operator cluster install (~30 min → ~2 min)~~ perf(scripts): speed up RHDH operator cluster install (~30 min → ~2 min) May 20, 2026

subhashkhileri temporarily deployed to internal May 20, 2026 08:26 — with GitHub Actions Inactive

subhashkhileri changed the title ~~perf(scripts): speed up RHDH operator cluster install (~30 min → ~2 min)~~ perf(scripts): speed up RHDH operator install using install-rhdh-catalog-source.sh (~30 min → ~2 min) May 20, 2026

chore(scripts): clean up comments to focus on WHY, not WHAT

318a09b

Assisted-by: Claude Code Co-Authored-By: Claude Code <noreply@anthropic.com>

subhashkhileri temporarily deployed to internal May 20, 2026 09:16 — with GitHub Actions Inactive

subhashkhileri temporarily deployed to internal May 20, 2026 11:33 — with GitHub Actions Inactive

subhashkhileri temporarily deployed to internal May 20, 2026 11:56 — with GitHub Actions Inactive

subhashkhileri force-pushed the perf/parallel-iib-bundle-processing branch from a19942f to 318a09b Compare May 20, 2026 12:00

subhashkhileri temporarily deployed to internal May 25, 2026 07:13 — with GitHub Actions Inactive

subhashkhileri closed this May 25, 2026

subhashkhileri reopened this May 25, 2026

subhashkhileri temporarily deployed to internal May 25, 2026 08:18 — with GitHub Actions Inactive

rhdh-qodo-merge Bot reviewed May 25, 2026

View reviewed changes

Comment thread .rhdh/scripts/install-rhdh-catalog-source.sh Outdated

Comment thread .rhdh/scripts/install-rhdh-catalog-source.sh Outdated

Comment thread .rhdh/scripts/install-rhdh-catalog-source.sh

Comment thread .rhdh/scripts/install-rhdh-catalog-source.sh

rhdh-qodo-merge Bot added Bug fix and removed Other labels May 25, 2026

rm3l reviewed May 26, 2026

View reviewed changes

Comment thread .rhdh/scripts/install-rhdh-catalog-source.sh

Comment thread .rhdh/scripts/install-rhdh-catalog-source.sh Outdated

subhashkhileri temporarily deployed to internal May 28, 2026 05:30 — with GitHub Actions Inactive

subhashkhileri force-pushed the perf/parallel-iib-bundle-processing branch from 998488a to 87c3ba3 Compare May 28, 2026 05:32

subhashkhileri temporarily deployed to internal May 28, 2026 05:32 — with GitHub Actions Inactive

rm3l approved these changes May 28, 2026

View reviewed changes

openshift-ci Bot assigned rm3l May 28, 2026

openshift-ci Bot added the lgtm label May 28, 2026

openshift-merge-bot Bot merged commit c417781 into redhat-developer:main May 28, 2026
11 of 13 checks passed

openshift-cherrypick-robot mentioned this pull request May 28, 2026

[release-1.10] perf(scripts): speed up RHDH operator install using install-rhdh-catalog-source.sh (~30 min → ~2 min) #2913

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

perf(scripts): speed up RHDH operator install using install-rhdh-catalog-source.sh (~30 min → ~2 min)#2870

perf(scripts): speed up RHDH operator install using install-rhdh-catalog-source.sh (~30 min → ~2 min)#2870
openshift-merge-bot[bot] merged 6 commits into
redhat-developer:mainfrom
subhashkhileri:perf/parallel-iib-bundle-processing

subhashkhileri commented May 20, 2026 •

edited

Loading

Uh oh!

rhdh-qodo-merge Bot commented May 20, 2026 •

edited

Loading

Uh oh!

rhdh-qodo-merge Bot commented May 25, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud Bot commented May 28, 2026

Uh oh!

rm3l left a comment

Uh oh!

rm3l commented May 28, 2026

Uh oh!

openshift-ci Bot commented May 28, 2026

Uh oh!

Uh oh!

rm3l commented May 28, 2026

Uh oh!

openshift-cherrypick-robot commented May 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

subhashkhileri commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

rhdh-qodo-merge Bot commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review Summary by Qodo

(Agentic_describe updated until commit 49ef790)

Walkthroughs

File Changes

Uh oh!

rhdh-qodo-merge Bot commented May 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud Bot commented May 28, 2026

Quality Gate passed

Uh oh!

rm3l left a comment

Choose a reason for hiding this comment

Uh oh!

rm3l commented May 28, 2026

Uh oh!

openshift-ci Bot commented May 28, 2026

Uh oh!

Uh oh!

rm3l commented May 28, 2026

Uh oh!

openshift-cherrypick-robot commented May 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

subhashkhileri commented May 20, 2026 •

edited

Loading

rhdh-qodo-merge Bot commented May 20, 2026 •

edited

Loading

(Agentic_describe updated until commit `49ef790`)

rhdh-qodo-merge Bot commented May 25, 2026 •

edited

Loading