Skip to content

feat: Use absolute FQDNs to simplify name resolution#1223

Open
olivergondza wants to merge 2 commits into
redhat-developer:masterfrom
olivergondza:absolute-fqdns
Open

feat: Use absolute FQDNs to simplify name resolution#1223
olivergondza wants to merge 2 commits into
redhat-developer:masterfrom
olivergondza:absolute-fqdns

Conversation

@olivergondza

Copy link
Copy Markdown
Collaborator

What type of PR is this?

Uncomment only one /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind bug
/kind cleanup
/kind failing-test
/kind enhancement
/kind documentation
/kind code-refactoring

What does this PR do / why we need it:

Have you updated the necessary documentation?

  • [no] Documentation update is required by this PR.
  • [no] Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

No functional changes are expected. Just reduced number of DNS queries.

Signed-off-by: Oliver Gondža <ogondza@gmail.com>
@openshift-ci openshift-ci Bot added the kind/enhancement New feature or request label Jul 17, 2026
@openshift-ci
openshift-ci Bot requested review from chetan-rns and trdoyle81 July 17, 2026 09:25
@openshift-ci

openshift-ci Bot commented Jul 17, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign trdoyle81 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Review Change Stack

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: cad49508-c34f-4804-9680-c3a8b1ec3ead

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Updated three Go dependency pins and revised OpenShift end-to-end TLS/Redis command assertions, including the Redis service hostname format and multiline expectation formatting.

Changes

Dependency and validation updates

Layer / File(s) Summary
Dependency version pins
go.mod
Updated the Argo CD operator, golang.org/x/mod, and golang.org/x/tools pins.
TLS and Redis command expectations
test/openshift/e2e/ginkgo/parallel/*_validate_*test.go
Updated the Redis service hostname expectation and reformatted TLS/Redis command assertions without changing their asserted argument order or unchanged values.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: jgwest

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: switching to absolute FQDNs to simplify name resolution.
Description check ✅ Passed The description is clearly related to the change and matches the stated goal of reducing DNS queries with no functional change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

Signed-off-by: Oliver Gondža <ogondza@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant