Bump argo cd 3.4.2#1158
Conversation
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
|
@olivergondza: The label(s) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
f0f739c to
d5868c1
Compare
|
Please change the version in https://github.com/redhat-developer/gitops-operator/blob/master/.ci-operator.yaml as well |
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
|
/retest |
|
@varshab1210, any hint what could cause this failures? It looks like arch mismatch between the host and the image. I have no idea what is the intended arch of either, nor where is that configured. Thanks |
Taking a look, seems to be related to arch mismatch |
|
/retest |
|
/test v4.19-images |
3 similar comments
|
/test v4.19-images |
|
/test v4.19-images |
|
/test v4.19-images |
|
/test v4.14-images |
2 similar comments
|
/test v4.14-images |
|
/test v4.14-images |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis pull request upgrades the Go toolchain from version 1.25.5 to 1.26.2 across build configurations and dependencies. It refreshes module dependencies via go.mod, migrates test code imports from standalone argoproj/gitops-engine to the argoproj/argo-cd/gitops-engine package path, and adjusts test Application specifications to use pointer-based fields for sync policy configuration. ChangesGo 1.26 Toolchain and Dependency Upgrade
🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Dockerfile`:
- Line 2: The Dockerfile currently pins the base image as "golang:1.26" which is
inconsistent with other build files that use "1.26.2"; update the FROM
instruction (the base image spec) in the Dockerfile to use "golang:1.26.2" so
the container toolchain matches .ci-operator.yaml,
openshift-ci/build-root/Dockerfile and go.mod.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Enterprise
Run ID: ef71326c-9970-4ae3-a9b5-2158d8a121bf
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (29)
.ci-operator.yamlDockerfilego.modopenshift-ci/build-root/Dockerfiletest/openshift/e2e/ginkgo/fixture/application/fixture.gotest/openshift/e2e/ginkgo/parallel/1-008_validate-custom-argocd-namespace_test.gotest/openshift/e2e/ginkgo/parallel/1-009_validate-manage-other-namespace_test.gotest/openshift/e2e/ginkgo/parallel/1-012_validate-managed-by-chain_test.gotest/openshift/e2e/ginkgo/parallel/1-023_validate_repo_server_tls_test.gotest/openshift/e2e/ginkgo/parallel/1-025-validate-managed-by-change_test.gotest/openshift/e2e/ginkgo/parallel/1-046_validate_application_tracking_test.gotest/openshift/e2e/ginkgo/parallel/1-054_validate_deploymentconfig_test.gotest/openshift/e2e/ginkgo/parallel/1-058_validate_prometheus_rule_test.gotest/openshift/e2e/ginkgo/parallel/1-070_validate_config_management_plugin_test.gotest/openshift/e2e/ginkgo/parallel/1-116_annotation-based-tracking_test.gotest/openshift/e2e/ginkgo/parallel/1-121_validate_image_updater_test.gotest/openshift/e2e/ginkgo/parallel/1-122_validate_user_defined_appproject.gotest/openshift/e2e/ginkgo/sequential/1-006_validate_machine_config_test.gotest/openshift/e2e/ginkgo/sequential/1-008_validate-4.9CI-Failures_test.gotest/openshift/e2e/ginkgo/sequential/1-010_validate-ootb-manage-other-namespace_test.gotest/openshift/e2e/ginkgo/sequential/1-027_validate_operand_from_git_test.gotest/openshift/e2e/ginkgo/sequential/1-037_validate_applicationset_in_any_namespace_test.gotest/openshift/e2e/ginkgo/sequential/1-053_validate_argocd_agent_principal_connected_test.gotest/openshift/e2e/ginkgo/sequential/1-059_validate_argocd_agent_terminal_streaming_test.gotest/openshift/e2e/ginkgo/sequential/1-064_validate_tcp_reset_error_test.gotest/openshift/e2e/ginkgo/sequential/1-102_validate_handle_terminating_namespaces_test.gotest/openshift/e2e/ginkgo/sequential/1-108_alternate_cluster_roles_cluster_scoped_instance_test.gotest/openshift/e2e/ginkgo/sequential/1-113_validate_namespacemanagement_test.gotest/openshift/e2e/ginkgo/sequential/1-120_repo_server_system_ca_trust.go
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
8322b40 to
c1227b6
Compare
|
/retest |
…into bump-argo-cd-3.4.2 Signed-off-by: Oliver Gondža <ogondza@gmail.com>
|
@olivergondza: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
/kind chore
What does this PR do / why we need it:
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #?
Test acceptance criteria:
How to test changes / Special notes to the reviewer: