Usr/akhil/tls feature#1151
Conversation
Signed-off-by: akhil nittala <nakhil@redhat.com>
…-agent components Signed-off-by: akhil nittala <nakhil@redhat.com>
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
…-agent components Signed-off-by: akhil nittala <nakhil@redhat.com>
…-agent components Signed-off-by: akhil nittala <nakhil@redhat.com>
…-agent components Signed-off-by: akhil nittala <nakhil@redhat.com>
| profile, err = tlspkg.FetchAPIServerTLSProfile(ctx, bootstrapClient) | ||
| if err != nil { | ||
| setupLog.Error(err, "unable to fetch cluster TLS profile") | ||
| os.Exit(1) | ||
| } |
There was a problem hiding this comment.
This needs to be handled properly for non-fatal errors without exiting, as we want the operator to work on non OpenShift clusters as well. Refer to #1157 or talk to @anandrkskd for more details.
There was a problem hiding this comment.
will check with anand on this
There was a problem hiding this comment.
post anand changes, will refactor it for non openshift cluster scenario.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2 participants
What type of PR is this?
What does this PR do / why we need it:
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #?
Test acceptance criteria:
How to test changes / Special notes to the reviewer: