Skip to content

fix: allow OAuth and RHSSO auth to be cancelled (#23844)#311

Draft
adietish wants to merge 1 commit into
redhat-developer:mainfrom
adietish:issue-23844
Draft

fix: allow OAuth and RHSSO auth to be cancelled (#23844)#311
adietish wants to merge 1 commit into
redhat-developer:mainfrom
adietish:issue-23844

Conversation

@adietish
Copy link
Copy Markdown
Collaborator

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 29, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 11ab8db1-9a8c-4b2d-94c0-a680f80dffa4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 29, 2026

Codecov Report

❌ Patch coverage is 0% with 178 lines in your changes missing coverage. Please review.
✅ Project coverage is 22.06%. Comparing base (71098f6) to head (9b91005).
⚠️ Report is 351 commits behind head on main.

Files with missing lines Patch % Lines
...gateway/auth/session/AbstractAuthSessionManager.kt 0.00% 65 Missing ⚠️
...steps/auth/OpenShiftOAuthAuthenticationStrategy.kt 0.00% 25 Missing ⚠️
...ateway/auth/session/OpenShiftAuthSessionManager.kt 0.00% 23 Missing ⚠️
...s/gateway/auth/session/RedHatAuthSessionManager.kt 0.00% 22 Missing ⚠️
...view/steps/auth/RedHatSSOAuthenticationStrategy.kt 0.00% 20 Missing ⚠️
...dhat/devtools/gateway/auth/session/BrowserLogin.kt 0.00% 8 Missing ⚠️
.../view/steps/auth/AbstractAuthenticationStrategy.kt 0.00% 5 Missing ⚠️
...devtools/gateway/auth/session/SsoLoginException.kt 0.00% 4 Missing ⚠️
...ools/gateway/view/steps/DevSpacesServerStepView.kt 0.00% 4 Missing ⚠️
...evtools/gateway/auth/session/AuthSessionManager.kt 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##            main     #311       +/-   ##
==========================================
+ Coverage   0.00%   22.06%   +22.06%     
==========================================
  Files          4      100       +96     
  Lines         26     4246     +4220     
  Branches       0      778      +778     
==========================================
+ Hits           0      937      +937     
- Misses        26     3190     +3164     
- Partials       0      119      +119     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Andre Dietisheim <adietish@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gateway: cancel OpenShift OAuth/Red Hat SSO takes several minutes to stop and errors

2 participants