feat: MTV migrate role - #88
Conversation
eb85f5a to
634a1cf
Compare
634a1cf to
d01b489
Compare
d01b489 to
185a777
Compare
Signed-off-by: Andrew Block <andy.block@gmail.com>
185a777 to
cc34e9a
Compare
tech2734
left a comment
There was a problem hiding this comment.
Good stuff — the custom module with unit tests and the recursive polling pattern are solid. A few things I noticed:
-
meta/main.ymlmissingrole_name: Should addrole_name: mtv_migratetogalaxy_infofor consistency with the other roles. -
Playbook host filtering:
vmf_migrate.ymltargetsmigration_clustersgroup but doesn't have a guard to only execute on the relevant host. Might need awhencondition or similar pattern to prevent running on all hosts in the group. -
Missing OCP connection params on
Create Migrationtask: Theredhat.openshift.k8scall inmain.ymldoesn't passhost,api_key,validate_certs, orca_cert— but the polling tasks in_poll_migration_status.ymldo. Probably works viaK8S_AUTH_*env vars in AAP, but it's inconsistent. -
README boilerplate: The static section still has the generic Ansible Galaxy scaffolding ("pre-requisites that may not be covered", example
string_arg1argument spec, etc.). The docsible section below is fine — just the static part could use a cleanup pass. -
_mtv_migrate_mtv_cutoverreferenced but not set: Inmigration.yml.j2, the template checks_mtv_migrate_mtv_cutoverbut I don't see aset_factthat populates it.mtv_migrate_warm_cutover_timeis the user-facing default — looks like either a missing fact or a variable name mismatch.
Description
Added
mtv_migraterole that enables triggering a migration from an existing planType of Change