feat(v2): Adding support for integrating AAP as part of a MTV hook - #83
Conversation
969b214 to
2e59bec
Compare
2e59bec to
2ec15e4
Compare
tech2734
left a comment
There was a problem hiding this comment.
Looks great — clean role structure, solid credential handling, and thorough README. Two minor nits:
-
Playbook task name:
playbooks/mtv_hook_invoke_aap.ymlline 12 says "Create MTV provider for source-target pair" — looks like a copy-paste from the provider playbook. Should probably be "Invoke AAP using MTV hook" or similar. -
Missing
role_nameinmeta/main.yml: The other roles in the collection explicitly setrole_name:ingalaxy_info. Worth addingrole_name: mtv_hook_invoke_aapfor consistency.
Neither is a blocker. Approving.
Signed-off-by: Andrew Block <andy.block@gmail.com>
a0f70a4 to
b8fc139
Compare
|
@tech2734 updated PR based on your feedback |
tech2734
left a comment
There was a problem hiding this comment.
Both previously flagged items are fixed — role_name added to meta and playbook task name corrected.
One minor nit: the play name in playbooks/mtv_hook_invoke_aap.yml still has a trailing "Source" (Invoke AAP From an MTV Hook Source) which reads a bit awkwardly. Not a blocker.
Description
Added a role/playbook to integrate into MTV hook framework
Type of Change
Testing
The role documentation has the steps necessary for setting up the integration. Until a new EE is published, the following standalone playbook can be used instead of the one provided in the playbooks dir as part of this PR