Feature/tzd 260005#9
Conversation
|
there are conflicts in the PR. please fix this |
recursivezero
left a comment
recursivezero
left a comment
There was a problem hiding this comment.
Format all files. use .code-workspace and format on save option; evey file have very bad spacing.
- Also resolve conflcts
There was a problem hiding this comment.
is this image required now? delete un ncessary image
| console.log({ image }); | ||
| const props = Astro.props; | ||
|
|
||
| const url = props.url; |
There was a problem hiding this comment.
use object destructuring
const {title, ..} = props;
| <article class="group h-full"> | ||
| <a | ||
| href={url} | ||
| target={url.startsWith("http") ? "_blank" : undefined} |
There was a problem hiding this comment.
why conditional ? and as we are using https
keep it simple
| </div> | ||
|
|
||
| <!-- Quick Links --> | ||
| <div> |
There was a problem hiding this comment.
create a quick links object and map the link object so that no duplicate code for each link
| class="input w-full rounded-[5px] border border-[#222] bg-[#111] p-[14px] placeholder:text-[#757575]" | ||
| type="email" | ||
| placeholder="Enter your email address" | ||
| class="h-12 w-full rounded-xl |
There was a problem hiding this comment.
why are we adding new line in class names? keep in the same line. if thus is automatically done then check your vs code settings. classes name should be in single line.
2 participants
Updates Included