[Deprecation] Deprecate ParameterBagToAutowireAttributeRector#954
Merged
Conversation
TomasVotruba
changed the title
…move its factory machinery
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ParameterBagToAutowireAttributeRectoris too specific and opinionated to maintain as a generic rule. The naming convention (snake_case param → camelCase var) and the decision to swapParameterBagInterfacefor#[Autowire(param:)]are project-specific choices that better belong in a custom rule.This marks the rule as deprecated via
DeprecatedInterface, so users get a runtime warning before it is removed:DeprecatedInterface→ Rector reports "rule is deprecated and will be removed"@deprecateddocblock pointing users to write a custom rule for their own ParameterBag →#[Autowire]conventionNot referenced in any set config, so no set changes needed.