[CodeQuality] Add EventSubscriberMethodReturnVoidRector#949
Merged
Conversation
…rn on subscribed event hooks
7e26f5e to
9a374b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new code quality rule
EventSubscriberMethodReturnVoidRector.Event subscriber methods that hook into an event must return
void— the event is a class passed by reference, so returning it has no effect.How it works
EventSubscriberInterfaceand hasgetSubscribedEvents().getSubscribedEvents()return array to collect hook method names. Supports all formats:'event' => 'method''event' => ['method', $priority]'event' => [['m1', 10], ['m2']]voidand rewritesreturn $event->setX(...)into$event->setX(...)(keeping an earlyreturn;inside branches, dropping it on the final statement).voidor returning a non-event value. Non-registered methods are left untouched.Before
After
Registered in the
symfony-code-qualityset.