Order optional command parameters last in InvokableCommandInputAttributeRector#944
Merged
Merged
Conversation
…ttributeRector (fixes rectorphp/rector#9546)
TomasVotruba
force-pushed
the
fix-optional-params-order-9546
branch
from
7bbf5da to
80a1a33
Compare
Member
Author
|
Already fixed, just adding the fixture here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#9546
Problem
InvokableCommandInputAttributeRectoremitted__invoke()parameters in the same order theaddArgument()/addOption()calls appeared inconfigure(). When an optional parameter (one with a default value) was declared before a required one, the generated method ended up with an optional parameter in front of a required parameter — which is invalid PHP and would have to be fixed up afterwards byOptionalParametersAfterRequiredRector.Fix
After building the
__invoke()parameter list, parameters are partitioned so required parameters (no default) keep their relative order and come first, followed by optional parameters (with a default). This guarantees optional parameters are always listed last.This is a fresh, passing take on the previously-closed #899 — the trailing-comma formatting problem reported there no longer reproduces with the current printer.
Tests
option_with_array_type.php.incfixture to reflect the corrected order.optional_option_before_required.php.incfixture covering an optional option declared before a required one.