[TypeDeclaration] Add ClosureReturnTypeFromAssertInstanceOfRector#8115
Merged
Conversation
424bde0 to
556df17
Compare
… assertInstanceOf-narrowed closure returns in test cases
556df17 to
21f5281
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
ClosureReturnTypeFromAssertInstanceOfRector— adds a return type to a closure inside a PHPUnitTestCasewhen the returned value is narrowed byassertInstanceOf().This is the critical case
ClosureReturnTypeRectorcannot cover: the closure body asserts the type, so the return is known. Plain closures withoutassertInstanceOf()are left toClosureReturnTypeRector.Scope
Closureonly (arrow functions cannot hold anassertInstanceOf()statement before the return)->is('PHPUnit\Framework\TestCase')assertInstanceOf()($this->or static) in the closure body; skipped otherwiseReturnTypeInferer(PHPStan phpunit type-specifier narrows the asserted variable)TypeDeclarationLevelFixtures: assertInstanceOf-narrowed return (transforms), no-assertInstanceOf (skip), outside test case (skip).