[CodeQuality] Add AddStubIntersectionVarToStubPropertyRector#700
Merged
Conversation
… intersection @var rules Generalize MockObjectPropertyDetector to collect both $this->create*() (MethodCall) and self::create*() (StaticCall). Widen both rules' class resolvers accordingly. Add static-call fixtures.
…eNeverUsedMockPropertyRector
…sectionVarToStubPropertyRector Iterate all native-Stub properties: derive the stubbed class from a setUp() createStub() arg when present, else from a bare single-class @var docblock. Absorbs and removes BareVarToStubIntersectionRector. Stub-first intersection ordering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
AddStubIntersectionVarToStubPropertyRectorto the mock-to-stub set.When a test property is typed as a bare native
StubandsetUp()assigns it viacreateStub(), add a@var Stub&MockedClassintersection docblock:→
Stub analog of
AddIntersectionVarToMockObjectPropertyRector.MockObjectPropertyDetectorgeneralized (parametric on class name + create-method) and shared by both rules.Skips: existing intersection
@var, non-test classes,MockObject-typed properties.