Feat: Ask for path before downloading from UI#2699
Open
fire-light42 wants to merge 1 commit intomasterfrom
Open
Feat: Ask for path before downloading from UI#2699fire-light42 wants to merge 1 commit intomasterfrom
fire-light42 wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think people have problems with downloads, not because they are broken, but because android is strict on permissions. Downloads will fail because the user has never granted CloudStream access, and then they will complain . This is a clear UX issue, that this pull request tries to fix, and may solve #2694 #2605.
On the very first download done this will ask for a custom download path, and only download it after the user has granted it.
Note 1: This is only for downloads initiated from a button, not long click. That would require architectural changes that goes beyond this pull request.
Note 2: This will conflict with #2689