Implement grok4.6's top priority improvements - #17
Merged
Conversation
added 7 commits
August 12, 2026 15:52
Integrate the 2026-08-12 operator/contributor review as an overall-ranked table (not per-category). Refresh file-size baseline, note fee-snapshot as partial, and point Q-16/Q-20/Q-22/Q-30/Q-37 at the matching R-ids.
Fee refresh already built chunks once; histogram, frontier, and weight_above still re-linearized the graph under the hub read lock. Store those chunks on the fee snapshot so request paths only Arc-load. Add list_live_meta for txid/fee/weight without cloning bodies and switch Esplora mempool stats/txids and RPC getmempool* to it. Count chunk rebuilds so tests pin one linearize per dirty refresh.
Mempool accept hopped to a new named OS thread per admit via run_detached_join. Tip-follow accept rates made that a spawn storm. Use a process-wide worker set (available_parallelism) for spawn_detached and join; confirm feed-ahead shares it. Test: 32 joins do not increase worker spawn count.
Replace local 1..=103 / 100+N POW remine loops in Electrum and MempoolHub default tests with rbitcoin_consensus::pad_empty_from. Starts Q-37; full suite wall not re-measured here.
mining_chunks_best_first rebuilt every cluster on every call. Cache the best-first list and invalidate on insert/remove/rebuild_from so fee refresh and histogram rebuild only after the live set changes.
The coverage job compiled cargo-llvm-cov from crates.io on every PR. Switch to taiki-e/install-action with cargo-llvm-cov@0.6.14 and mark Q-22/R-05 fixed in quality.md.
The verbose loop still destructured four tuple fields after switching getrawmempool to list_live_meta (txid, fee, weight).
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
CodeQL flagged the coverage job for using the floating v2 tag on a third-party Action. Pin install-action to v2.85.12 (b20dedce73af6905cdc30d6611090c9b67557c8d) so the workflow is immutable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.