Skip to content

Fix legacy_swiftui_aspect_ratio not preserving whitespace (#6883) - #6885

Open
CraigSiemens wants to merge 1 commit into
realm:mainfrom
CraigSiemens:fix-legacy-swiftui-aspect-ratio-lost-whitespace
Open

Fix legacy_swiftui_aspect_ratio not preserving whitespace (#6883)#6885
CraigSiemens wants to merge 1 commit into
realm:mainfrom
CraigSiemens:fix-legacy-swiftui-aspect-ratio-lost-whitespace

Conversation

@CraigSiemens

Copy link
Copy Markdown
Contributor

Fixes #6883 by editing the baseName of the MemberAccessExprSyntax to preserve the existing trivia (whitespace) around the function call.

Previously it was creating a new expression for the function call so the result would always be on one line.

@SwiftLintBot

Copy link
Copy Markdown
20 Messages
📖 Building this branch resulted in a binary size of 28460.6 KiB vs 28460.51 KiB when built on main (0% larger).
📖 Linting Aerial with this PR took 0.09 s vs 0.09 s on main (0% slower).
📖 Linting Alamofire with this PR took 0.12 s vs 0.13 s on main (7% faster).
📖 Linting Brave with this PR took 0.41 s vs 0.42 s on main (2% faster).
📖 Linting Brigade with this PR took 1.0 s vs 1.0 s on main (0% slower).
📖 Linting DuckDuckGo with this PR took 1.91 s vs 1.97 s on main (3% faster).
📖 Linting Firefox with this PR took 0.73 s vs 0.76 s on main (3% faster).
📖 Linting Kickstarter with this PR took 0.45 s vs 0.47 s on main (4% faster).
📖 Linting Moya with this PR took 0.1 s vs 0.11 s on main (9% faster).
📖 Linting NetNewsWire with this PR took 0.21 s vs 0.21 s on main (0% slower).
📖 Linting Nimble with this PR took 0.16 s vs 0.13 s on main (23% slower).
📖 Linting PocketCasts with this PR took 0.55 s vs 0.53 s on main (3% slower).
📖 Linting Quick with this PR took 0.11 s vs 0.09 s on main (22% slower).
📖 Linting Realm with this PR took 0.21 s vs 0.19 s on main (10% slower).
📖 Linting Sourcery with this PR took 0.18 s vs 0.17 s on main (5% slower).
📖 Linting Swift with this PR took 0.23 s vs 0.23 s on main (0% slower).
📖 Linting SwiftLintPerformanceTests with this PR took 3.72 s vs 3.73 s on main (0% faster).
📖 Linting VLC with this PR took 0.18 s vs 0.21 s on main (14% faster).
📖 Linting Wire with this PR took 0.8 s vs 0.82 s on main (2% faster).
📖 Linting WordPress with this PR took 0.63 s vs 0.61 s on main (3% slower).

Generated by 🚫 Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Applied fix for legacy_swiftui_aspect_ratio violations doesn't preserve newlines

2 participants