Revive excludedPaths by stopping double resolution - #6825
Open
tomotakatakahashi wants to merge 1 commit into
Open
Revive excludedPaths by stopping double resolution#6825tomotakatakahashi wants to merge 1 commit into
tomotakatakahashi wants to merge 1 commit into
Conversation
Generated by 🚫 Danger |
tomotakatakahashi
marked this pull request as ready for review
July 15, 2026 14:56
This commit stops resolving a path to an absolute path in Configuration.groupFiles. This will resolve the issue mentioned in comments in realm#6795 that the "excluded" configuration in .swiftlint.yml is ignored when file paths are passed as arguments.
tomotakatakahashi
force-pushed
the
exclusion-ignored-6795
branch
from
July 15, 2026 14:59
3e1a6c8 to
40ce904
Compare
SimplyDanny
requested changes
Aug 21, 2026
SimplyDanny
left a comment
SimplyDanny
left a comment
Collaborator
There was a problem hiding this comment.
This change is causing changes in scanned OSS repositories. That's definitely unexpected and should be revisited.
Author
|
Thank you for your feedback. I wasn't entirely clear on the comment from SwiftLintBot, but I now understand that I need to address the warnings. I will try to look into this, though my time might be a bit limited. |
Author
|
@SimplyDanny After a little investigation, I now think the changes in the scanned OSS repositories are expected. The files listed under "This PR fixed a violation":
are all excluded via .swiftlint.yml files (1, 2, 3, 4) in that repository. So if the main branch were working correctly, these files shouldn't produce any violations at all. Therefore "This PR fixed a violation" messages are desirable and expected. My guess is that the double-resolution bug was introduced by PR #6636, but somehow SwiftLintBot couldn't catch it. Could you take a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This commit stops resolving a path to an absolute path in
Configuration.groupFiles. This will resolve the issue mentioned in comments in #6795 that theexcludedconfiguration in .swiftlint.yml is ignored when file paths are passed as arguments.Context
The
excludedconfiguration is sometimes ignored since v0.64.0 (#6795 (comment)). The issue seems to happen when file paths are passed as arguments (for example, runningswiftlint Foo.swift Bar.swiftinstead ofswiftlint .orswiftlint).Using a debugger, I found that
excludedRelativePathin the diff was actually not a relative path, because it had already been resolved in Configuration+Parsing.swift. As a result,let excludedPathin the diff was being doubly-resolved to an invalid path like"file:///Users/username/projects/foo/Users/username/projects/foo/MyPackage/Package.swift".Test
Arguments Passed On LaunchNoProblem.swift MyPackage/Package.swift, running the swiftlint scheme:Comment