Improve space media fragment#235
Open
JayPanoz wants to merge 4 commits into
Open
Conversation
Contributor
Author
|
@chocolatkey Note this is a breaking change in practice, due to the Return Type changing. It was not used in the codebase but it can impact existing consumers of shared models. |
Member
|
@JayPanoz thanks for letting me know. I actually just worked on this type of parsing for the Go toolkit, you can see it here if you want to compare the two implementations: https://github.com/readium/go-toolkit/blob/html-guided-navigation/pkg/guidednavigation/fragments.go#L449 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While fixing
LocatorLocations.time()I noticedspacewas marked TODO as well.This improves parsing, although it is a breaking change as the Type was updated in the process.