[WORKER] Upload the bootcdregtest ISOs as well

[HBelusca]

These ISOs are uploaded to: https://iso.reactos.org/temp/

JIRA issue: ONLINE-709

Uploading the bootcdregtest ISOs are meant to be used only for diagnostics purposes, e.g. if a build crashes on a testbot and provides a given stack trace, one could then download the corresponding test ISO locally and spelunk into the offending module(s) to check what's going on. This is mandatory if the crash happens within a built test module (rostest), since those aren't included by default in the regular uploaded bootcd.

TODO

• Find a way to schedule a regular (weekly?) cleanup of old ISOs in https://iso.reactos.org/temp/ .

[tkreuzer]

Regarding the cleanup: could we just check for old isos (by creation date) and delete them before uploading a new one?

[HBelusca]

This is the command I came up with, in order to delete ISOs/7z archives in the remote /temp/ directory, if they are older than 1 week.

• I use mtime (data modified time) because in general on *nix there is no concept of "creation date". Using ctime instead would mean I'm looking at the metadata changes, which wasn't my intent.
• I use -mindepth 1 -maxdepth 1 in order to explicitly restrict the search to the first level inside this directory -- if there were to be subdirectories inside it, I don't want to recurse inside them. Iirc. these options are gnu-specific... (see https://unix.stackexchange.com/a/298593 and other comments in it).
• I use -delete because it's claimed to be faster than piping the result to rm command (see e.g. the xargs command examples). However this is a gnu-specific option, and might not be present everywhere (see https://superuser.com/a/1222237 and https://unix.stackexchange.com/questions/167823/finds-exec-rm-vs-delete ). If it were to not work on the machine, then replace -delete by: -print0 | xargs -0r -n1 rm -f --

Side-note: I tested locally this command by using -mmin option instead of -mtime in order to be able to specify a time amount in minutes (and not in days).

[HBelusca]

Note that the "1 week" limit was arbitrarily taken; maybe this needs to be reduced to just a couple of days, or whatever?

[tkreuzer]

I think a week should be fine.

[HBelusca]

@tkreuzer @DarkFire01 Could you guys check again the proposed solution?

[tkreuzer]

I assume it's fine.

[HBelusca]

I assume it's fine.

I guess too, but it would be of interest to test that on a testbed (adapted from the production server)