Skip to content

⚡ [Performance] Parallelize directory creation in DownloadTask #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sunnylqm merged 2 commits into from
Apr 14, 2026
Merged

⚡ [Performance] Parallelize directory creation in DownloadTask #541

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e020008
Optimize directory creation with Promise.all in copyFromResource
google-labs-jules[bot] Apr 14, 2026
4c9bde5
Delete pr_description.md
sunnylqm Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions harmony/pushy/src/main/ets/DownloadTask.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,9 +526,9 @@ export class DownloadTask {
targets.map(t => t.substring(0, t.lastIndexOf('/'))).filter(Boolean),
),
];
for (const dir of parentDirs) {
await this.ensureDirectory(dir);
}
await Promise.all(
parentDirs.map(dir => this.ensureDirectory(dir)),
);
await Promise.all(
targets.map(target => this.writeFileContent(target, mediaBuffer.buffer)),
);
Expand All @@ -541,9 +541,9 @@ export class DownloadTask {
targets.map(t => t.substring(0, t.lastIndexOf('/'))).filter(Boolean),
),
];
for (const dir of parentDirs) {
await this.ensureDirectory(dir);
}
await Promise.all(
parentDirs.map(dir => this.ensureDirectory(dir))
);
if (fileIo.accessSync(firstTarget)) {
await fileIo.unlink(firstTarget);
}
Expand Down