chore(renovate): hold the generator and analyzer at the Roslyn baseline - #59
Merged
Merged
Conversation
- Microsoft.CodeAnalysis.CSharp and .CSharp.Workspaces no longer receive update PRs. Both ship in the version-less analyzers/dotnet/cs folder, and a compiler refuses to load a generator built against a newer Roslyn than itself, so raising the 4.8.0 floor drops every consumer on an older SDK. - Microsoft.CodeAnalysis.Analyzers keeps moving; it supplies analyzer-authoring rules and has no bearing on the load floor.
1 task
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
=======================================
Coverage 97.63% 97.63%
=======================================
Files 228 228
Lines 7772 7772
Branches 1066 1066
=======================================
Hits 7588 7588
Misses 143 143
Partials 41 41 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Build configuration.
What is the new behavior?
Microsoft.CodeAnalysis.CSharpandMicrosoft.CodeAnalysis.CSharp.Workspacesno longer receive dependency update PRs. The generator and analyzer stay on the Roslyn 4.8.0 baseline until someone raises the minimum supported SDK deliberately.Microsoft.CodeAnalysis.Analyzerscontinues to update. It supplies analyzer-authoring rules and has no bearing on which compilers can load the generator.What is the current behavior?
Both packages were treated as ordinary dependencies, so each Roslyn release produced an update PR proposing to raise the floor. #45 is the current one, moving 4.8.0 to 4.14.0.
The pin is a compatibility decision rather than a maintenance lag, and the reason is already recorded in both project files: the generator and analyzer ship in the version-less
analyzers/dotnet/csfolder, and a compiler will not load a generator or analyzer built against a newer Roslyn than itself. Building against 4.8.0 is what keeps consumers on VS 2022 17.8 and the .NET 8.0.1xx SDK working. Accepting one of those update PRs would silently drop them.What might this PR break?
ReactiveUI.Binding.SourceGenerators.csproj. Raising the baseline is now an explicit edit to the project files and this rule, which is the intent.Checklist
mainbranchAdditional information
The rule matches the two package names exactly rather than a
Microsoft.CodeAnalysis.*prefix, so a future package under that prefix is not silently frozen along with them.Supersedes #45, which should be closed rather than merged.