Feat: sum benchmarks#1118
Open
giard-alexandre wants to merge 3 commits into
Open
Conversation
JakenVeina
requested changes
Jun 24, 2026
| source.AddOrUpdate(replacement, key: id); | ||
| replaceChangeSets.Add(source.CaptureChanges()); | ||
| } | ||
| _replaceChangeSets = replaceChangeSets; |
Collaborator
There was a problem hiding this comment.
You've generated an invalid sequence of changes for all of these, except for _addChangeSets. source.CaptureChanges() also clears out the changes buffer, so when you get around to sending _replaceChangeSets to your operator, what you've got is nothing but Replace changes that refer to items that never had an Add. Apparently, the existing implementation of .Sum() doesn't care, but your new one might.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds some benchmarks to the Sum aggregate operator.
This is basically a preamble to the full rewrite of the Sum operator, as described in #1031 (comment)